[core] fix(Section): Section header should only render if title is provided #6321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove now-unnecessary title null checksBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
prettierBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
gluxon
approved these changes
Aug 18, 2023
| @@ -74,6 +74,7 @@ export interface SectionProps extends Props, Omit<HTMLDivProps, "title">, React. | |||
|
|
|||
| /** | |||
| * Element to render on the right side of the section header. | |||
| * Note that the header will only be rendered if `title` is provided. | |||
There was a problem hiding this comment.
Nice catch copying this comment over from the other props that are no-ops if title is not provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6324
Checklist
Changes proposed in this pull request:
Hide the header if there's no passed in
titlepropReviewers should focus on:
Maybe we should have a separate prop for this? It seems a bit strange that we'd just ignore
subtitleandrightElementif there's notitle...Screenshot