Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix Section tests broken by semantic merge conflict #6327

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

pgoldberg
Copy link
Contributor

@pgoldberg pgoldberg commented Aug 18, 2023

Fixing section tests, failing due to a semantic merge conflict between #6321 and #6326

If title isn't provided, the header isn't rendered

@pgoldberg pgoldberg changed the title fix section test [core] Fix Section tests broken by semantic merge conflict Aug 18, 2023
@pgoldberg pgoldberg marked this pull request as ready for review August 18, 2023 21:43
@pgoldberg pgoldberg enabled auto-merge (squash) August 18, 2023 21:44
@adidahiya
Copy link
Contributor

whoops, empty string is falsy

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@pgoldberg pgoldberg merged commit 8103414 into develop Aug 18, 2023
11 of 12 checks passed
@pgoldberg pgoldberg deleted the pgoldberg/fixSectionTest branch August 18, 2023 21:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants