[core] fix(AnchorButton): don't show text underline on hover

[mud]

Fixes

The AnchorButton when hovered will underline the text. This is a regression.

Checklist

• Includes tests
• Update documentation

Changes proposed in this pull request:

Explicitly list text-decoration: none to override the a:hover style applied.

Reviewers should focus on:

Not sure why this regression happened, but maybe because the generated CSS ordering was changed for some reason? Here's the result of the fix:

Screenshot

[adidahiya]

remove unnecessary style

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

[adidahiya]

That's a surprising regression. The relevant bit of button styling code has not been touched in 6-7 years. However, I can repro the bug in all browsers on macOS (Chrome, Firefox, Safari, Edge) and in Edge on Windows (via Parallels).

I bisected the regression to your EntityTitle commit on develop: aaf1fa9

The previous commit does not have the regression: ea28092

(click the "documentation" link in the preview comment at the bottom of the commit page)

🤔

[adidahiya]

I can imagine this causing a styling regression in some rare case where a Blueprint user is trying to create a kind of "button link" component which does show a text underline (cue relevant xkcd), but I think this change is the safest way to fix the problem at hand and should generally be OK. We are planning to add a "button link" component to the design system soon which should address that use case anyway.

[mud]

That's really odd. I guess the styles introduced in EntityTitle somehow cause webpack to change the ordering of the output css.