Remove unnecessary typography import to remove hover underline in AnchorButton #6640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary typography importBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adidahiya
approved these changes
Jan 10, 2024
| @@ -33,7 +32,6 @@ | |||
| flex-direction: row; | |||
| gap: 0.5 * $pt-grid-size; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
LGTM aside from this deleted line which is failing stylelint
lintBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Unnecessary underline in
AnchorButtonwas removed in #6636 by overriding the hover. Turns out, the actual issue was caused by unnecessary import oftypography.scssinEntityTitle.This PR reverts #6636 and removes the unnecessary import.
Checklist
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot