Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] fix(OverlayToaster): correct type for createAsync domRenderer #6689

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[core] fix(OverlayToaster): correct type for createAsync domRenderer #6689

merged 1 commit into from
Jan 31, 2024

Conversation

adidahiya
Copy link
Contributor

Before this PR

with the latest core v5.9.0 release:

image

Changes proposed in this pull request:

Fix the type of domRenderer to be compatible with createRoot()

@adidahiya
Copy link
Contributor Author

[core] fix(OverlayToaster): correct type for createAsync domRenderer callback

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit 711fbcf into develop Jan 31, 2024
11 of 12 checks passed
@adidahiya adidahiya deleted the ad/fix-dom-mount-options branch January 31, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adidahiya