Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] fix(OverlayToaster): correct type for createAsync domRenderer #6689

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[core] fix(OverlayToaster): correct type for createAsync domRenderer #6689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/core/src/common/utils/mountOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@

import type * as React from "react";

/** Identical to `import("react-dom").Container`, copied here to avoid an unncessary type dependency. */
type Container = Element | Document | DocumentFragment;

/**
* Generic options interface for Blueprint APIs which imperatively mount a React component to the
* DOM using `"react-dom"`: `OverlayToaster.create`, `showContextMenu`, etc.
Expand All @@ -42,7 +39,7 @@ export interface DOMMountOptions<P> {
*/
domRenderer?: (
element: React.ReactElement<P>,
container: Container | null,
container: Element | DocumentFragment,
) => React.Component<P, any> | Element | void;

/**
Expand Down