Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add layout engine icons #6705

Merged
merged 8 commits into from
Jun 28, 2024
Merged

Add layout engine icons #6705

merged 8 commits into from
Jun 28, 2024

Conversation

hijiajiajiajia
Copy link
Contributor

@hijiajiajiajia hijiajiajiajia commented Feb 9, 2024 •
edited by evansjohnson
Loading

Add layout engine icons

before:
Screenshot 2024-06-28 at 11 24 44 AM

after:
Screenshot 2024-06-28 at 11 24 24 AM

@adidahiya
Copy link
Contributor

rename

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

adidahiya
adidahiya suggested changes Feb 13, 2024
View reviewed changes
packages/icons/icons.json Outdated Show resolved Hide resolved
packages/icons/icons.json Show resolved Hide resolved
@hijiajiajiajia hijiajiajiajia marked this pull request as draft June 11, 2024 00:06
@svc-palantir-github
Copy link

fix compile

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@hijiajiajiajia hijiajiajiajia marked this pull request as ready for review June 11, 2024 01:23
@svc-palantir-github
Copy link

update name

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@evansjohnson evansjohnson removed the request for review from adidahiya June 28, 2024 14:20
@evansjohnson evansjohnson self-assigned this Jun 28, 2024
@evansjohnson evansjohnson mentioned this pull request Jun 28, 2024
Merged
2 tasks
evansjohnson
evansjohnson reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@evansjohnson evansjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing stale group wrappers from when there were clip paths defined

resources/icons/20px/layout-two-rows.svg Outdated Show resolved Hide resolved
resources/icons/20px/layout-two-columns.svg Outdated Show resolved Hide resolved
resources/icons/20px/layout-top-row-two-tiles.svg Outdated Show resolved Hide resolved
resources/icons/20px/layout-top-row-three-tiles.svg Outdated Show resolved Hide resolved
resources/icons/20px/layout-three-rows.svg Outdated Show resolved Hide resolved
resources/icons/16px/layout-right-column-three-tiles.svg Outdated Show resolved Hide resolved
resources/icons/16px/layout-left-column-two-tiles.svg Outdated Show resolved Hide resolved
resources/icons/16px/layout-left-column-three-tiles.svg Outdated Show resolved Hide resolved
resources/icons/16px/layout-bottom-row-two-tiles.svg Outdated Show resolved Hide resolved
resources/icons/16px/layout-bottom-row-three-tiles.svg Outdated Show resolved Hide resolved
@svc-palantir-github
Copy link

Apply suggestions from code review

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@evansjohnson evansjohnson merged commit 3f2eb80 into develop Jun 28, 2024
12 of 14 checks passed
@evansjohnson evansjohnson deleted the jiajial/add-layout-icons branch June 28, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya requested changes

@evansjohnson evansjohnson evansjohnson approved these changes

@gluxon gluxon gluxon approved these changes

Assignees

@evansjohnson evansjohnson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hijiajiajiajia @adidahiya @svc-palantir-github @gluxon @evansjohnson