Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icons] Add CSSStyle, DataSync and Excavator icons #6867

Merged
merged 4 commits into from
Jun 28, 2024

Conversation

zaini
Copy link
Contributor

@zaini zaini commented Jun 25, 2024

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Add CSSStyle, DataSync and Excavator icons

Reviewers should focus on:

Icon design and the changes in icons.json

Screenshot

image

Reach out to xinyifu on Slack for design nits.

@changelog-app
Copy link

changelog-app bot commented Jun 25, 2024

Generate changelog in packages/icons/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

[Icons] Add CSSStyle, DataSync and Excavator icons

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

Add generated changelog entries

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Comment on lines 13 to 17
<defs>
<clipPath id="clip0_9017_3">
<rect width="16" height="16" fill="white" />
</clipPath>
</defs>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove clipPath

Screenshot 2024-06-28 at 10 53 40 AM

similar to #6705 (comment)

resources/icons/16px/excavator.svg Outdated Show resolved Hide resolved
resources/icons/20px/excavator.svg Outdated Show resolved Hide resolved
@svc-palantir-github
Copy link

Apply suggestions from code review

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

evansjohnson
evansjohnson previously approved these changes Jun 28, 2024
@policy-bot policy-bot bot dismissed evansjohnson’s stale review June 28, 2024 17:13

Invalidated by push of db5de0b

@svc-palantir-github
Copy link

merge conflict

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@evansjohnson evansjohnson merged commit 6e0ce0e into develop Jun 28, 2024
13 checks passed
@evansjohnson evansjohnson deleted the zaini/add-new-icons branch June 28, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants