Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix(tabs): remove large gap between vertical tabs #6885

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

gluxon
Copy link
Contributor

@gluxon gluxon commented Jul 1, 2024

Changes

Fixes an issue reported here #6834 (comment). This was a recent regression in a fix to better support RTL tabs.

Before

Screenshot 2024-07-01 at 5 08 06 PM

After

Screenshot 2024-07-01 at 5 08 29 PM

@gluxon gluxon force-pushed the gluxon/fix-vertical-tab-gaps branch from e16b0c9 to e7830f1 Compare July 1, 2024 21:09
@gluxon gluxon changed the title Fix large gap between vertical tabs [core] fix(tabs): remove large gap between vertical tabs Jul 1, 2024
@gluxon gluxon mentioned this pull request Jul 1, 2024
2 tasks
@gluxon gluxon force-pushed the gluxon/fix-vertical-tab-gaps branch 2 times, most recently from a7b6d6c to bbc0dd2 Compare July 1, 2024 21:19
@gluxon gluxon force-pushed the gluxon/fix-vertical-tab-gaps branch from bbc0dd2 to fe6c84c Compare July 1, 2024 21:22
@svc-palantir-github
Copy link

Fix large gap between vertical tabs

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Copy link
Contributor

@evansjohnson evansjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gluxon gluxon marked this pull request as ready for review July 2, 2024 15:21
@gluxon gluxon merged commit 8329a32 into develop Jul 2, 2024
12 of 13 checks passed
@gluxon gluxon deleted the gluxon/fix-vertical-tab-gaps branch July 2, 2024 15:22
gluxon added a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants