Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[core] fix(Tabs): use gap instead of margin to fix RTL spacing (#6834)" #6887

Closed
wants to merge 2 commits into from

Conversation

gluxon
Copy link
Contributor

@gluxon gluxon commented Jul 2, 2024

Changes

Reverts the following PRs

We saw a few problems rolling this out:

  • A lot of users are overriding margin on .bp5-tab-list children. The new gap value adds additional spacing that's unexpected in this case.
  • @evansjohnson caught a <TabsExpander /> usage that overflowed items with the switch to gap.

@gluxon gluxon marked this pull request as ready for review July 2, 2024 18:30
@svc-palantir-github
Copy link

Revert "[core] fix(Tabs): use gap instead of margin to fix RTL spacing (#6834)"

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@evansjohnson
Copy link
Contributor

I opened #6894 to better handler the TabsExpander case, but I think we should try to push through this change.

If we do a revert we're stuck not supporting RTL gracefully without a direction forward, and the main concerns around breaking changes due to the style change turned out to be non issues (I was previewing in an environment that had both old and new styles applied).

@evansjohnson
Copy link
Contributor

closing - planning to release without a full revert of this change and just the fix for the vertical tab spacing since this wasn't as bad as originally feared

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants