Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote FieldNameValidator warnings to errors #974

Open
blakehurlburt opened this issue Nov 8, 2021 · 0 comments
Open

Promote FieldNameValidator warnings to errors #974

blakehurlburt opened this issue Nov 8, 2021 · 0 comments

Comments

@blakehurlburt
Copy link

Motivation

Currently FieldName and FieldNameValidator warn you when adding invalid field names. One frequent issue is developers copying snake_case naming conventions from other places, not realizing this is supported for legacy endpoints only, and not seeing the warnings.

Proposal

We should promote these warnings to errors if we really want to migrate off this naming convention in the long term. Probably need to do it behind a feature flag for now, so that individual projects have an escape hatch when needed. Also would be good to document the semantics for whether fixing this is an API break and/or an ABI break, so devs can decide whether it's possible to switch or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant