Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #974: The Conjure parser supports a --strict flag #975

Closed
wants to merge 2 commits into from

Conversation

carterkozak
Copy link
Contributor

Before this PR

warnings, but no way to fail when they're introduced

After this PR

==COMMIT_MSG==
fix #974: The Conjure parser supports a --strict flag to fail on non-camel-case fields
==COMMIT_MSG==

Possible downsides?

gradle-conjure doesn't support additional arbitrary args like the other generators yet, this will require a feature there as well.

@changelog-app
Copy link

changelog-app bot commented Nov 8, 2021

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

fix #974: The Conjure parser supports a --strict flag to fail on non-camel-case fields

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from robert3005 November 8, 2021 22:31
@carterkozak carterkozak removed the request for review from robert3005 November 8, 2021 22:31
@stale
Copy link

stale bot commented Jan 9, 2022

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

@stale stale bot added the stale label Jan 9, 2022
@stale stale bot closed this Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote FieldNameValidator warnings to errors
2 participants