Delete baseline-versions (and nebula.dependency-recommender) #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
iamdanfox
commented
Jan 14, 2020
| @@ -11,7 +11,6 @@ dependencies { | |||
| compile 'com.diffplug.spotless:spotless-plugin-gradle' | |||
| compile 'com.google.errorprone:error_prone_refaster' | |||
| compile 'com.google.guava:guava' | |||
| compile 'com.netflix.nebula:nebula-dependency-recommender' | |||
| compile 'com.palantir.configurationresolver:gradle-configuration-resolver-plugin' | |||
There was a problem hiding this comment.
if we're queuing up breaks, perhaps we should cut this one too?
|
Big fan, this has been a long time coming 👍 |
iamdanfox
changed the title
iamdanfox
force-pushed
the
dfox/delete-baseline-versions
branch
from
f591cbd to
6e60788
Compare
This was referenced Jan 23, 2020
This was referenced Jan 24, 2020
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
To avoid breaking consumers, baseline has bundled nebula.dependency-recommender for a long time, even though we discourage people from using it (as we now recommend GCV).
Here's a recent example of nebula causing people confusion: #1167.
After this PR
==COMMIT_MSG==
The deprecated
com.palantir.baseline-versionsplugin has been deleted, as we recommended using gradle-consistent-versions instead. (Alternatively, you can still manually set up nebula.dependency-recommender).==COMMIT_MSG==
As a follow-up, we might want to excavate a cleanup of the
com.palantir.baseline-versions.disable=trueline from people's gradle.properties.fixes #1131
Possible downsides?