Excavator: Upgrades Baseline to the latest version #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svc-excavator-bot
force-pushed
the
roomba/latest-baseline-oss
branch
2 times, most recently
from
79a7d40 to
b2c49c8
Compare
svc-excavator-bot
force-pushed
the
roomba/latest-baseline-oss
branch
from
b2c49c8 to
c6db7d5
Compare
dansanduleac
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excavator is a bot for automating changes across repositories.
Changes produced by the roomba/latest-baseline-oss check.
Release Notes
2.35.2
2.36.0
StreamEmptywith error proneStreamOfEmptyto allow refactors to retain type arguments.2.37.0
AssertjPrimitiveComparisonfor primitive comparisonsPrefer using AssertJ fluent comparisons over logic in an assertThat
statement for better failure output. assertThat(a == b).isTrue()
failures report 'expected true' where assertThat(a).isEqualTo(b)
provides the expected and actual values.
2.38.0
> 40% speedup when run against Google's codebase with errors enabled.
2.39.0
mockito-errorproneto get Mockito error-prone checks.2.40.0
CatchSpecificityandThrowSpecificityto avoid unnecessarily broad throwables.Prefer more specific catch types than Exception and Throwable.
When methods are updated to throw new checked exceptions they expect
callers to handle failure types explicitly. Catching broad types defeats
the type system. By catching the most specific types possible we
leverage existing compiler functionality to detect unreachable code.
SafeArg.of(when it's a last argument) are no longer unexpectedly split onto the next line.2.40.1
PreferJavaTimeOverloaderror-prone check is turned off as it produces noisy false positives relating to custom AssertJ utilities.2.40.2
2.41.0
No documented user facing changes
2.42.0
NonComparableStreamSortto validate that stream types implement comparable, as opposed to validating that casting to comparable does not cause a compiler error.This commit reduces the severity to WARNING because it's
possible that the check will flag code that happens to work
today, but we strongly recommend against sorting streams of
a type that is not directly comparable without a custom
comparator because it is likely to break later due to lack
of enforcement by the type system.
not enabled by default by providing a comma delimited list of check
names to the
-PerrorProneApplyoption.2.43.0
Automated release, no documented user facing changes
2.44.0
can result in subtle resource leaks. Prefer replacing existing gauge
values using
registerWithReplacement.This check doesn't apply unless a new enough version of Tritium
is available on the compilation classpath.
2.44.1
2.45.0
diff<br>- if (condition) statement;<br>+ if (condition) {<br>+ statement;<br>+ }<br>2.45.1
baseline-ideaplugin now correctly marks test resources as test resources in IntelliJ.2.46.0
2.47.0
com.palantir.baseline-class-uniquenessplugin now records conflicts in abaseline-class-uniqueness.lockfile. This should be checked-in to git and makes it easier to incrementally improve projects, rather than requiring a big-bang migration.2.48.0
2.48.1
./gradlew --write-lockswill now update the baseline-class-uniqueness.lock file.2.48.2
2.48.3
2.49.0
2.49.1
LoggerEnclosingClassedge cases for type parameters and anonymous classes2.49.2
The value for Report xml property 'required' is final and cannot be changed any further.in Gradle 6.1 are now fixed for thecom.palantir.junit-reportsplugin.3.0.0
./gradlew resolveConfigurationstask. We no longer run this on CI, but if you want to keep using it, feel free to depend on the plugin directly.com.palantir.baseline-versionsplugin has been deleted, as we recommended using gradle-consistent-versions instead. (Alternatively, you can still manually set up nebula.dependency-recommender).3.1.0
3.1.1
UnnecessaryLambdaArgumentParentheseshandling explicitly typed primitive lambda args3.2.0
3.2.1
ParenPadrule is turned off when using palantir-java-format, to avoid disagreements that can't be fixed by the user.3.2.2
3.3.0
./gradlew compileJava -Pcom.palantir.baseline-error-prone.disableturns off error-prone, to allow compilation on Java 13 which is not yet supported by error-prone.3.4.0
.baseline/copyright../gradlew test -Drecreate=truewill ensure the"recreate"system property is passed through to Java correctly.3.4.1
3.4.2
To enable or disable this check, please contact the maintainers of Excavator.