baseline-circleci no longer applies configuration resolver plugin #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdanfox
changed the base branch from
develop
to
dfox/delete-baseline-versions
iamdanfox
changed the title
CRogers
approved these changes
Jan 23, 2020
iamdanfox
changed the title
iamdanfox
changed the base branch from
dfox/delete-baseline-versions
to
develop
iamdanfox
force-pushed
the
dfox/delete-configuration-resolver
branch
from
adc02f1 to
ed4fae9
Compare
This was referenced Jan 23, 2020
This was referenced Jan 24, 2020
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
We used to recommend
./gradlew resolveConfigurationsback when Circle1 had mutable caches (as it would nicely pre-warm them).However, we've found that actually in Circle2, it is more efficient to just save a job-specific cache right at the end of each job. This ensures that the caches contain only what's necessary for that job, rather than all configurations.
After this PR
==COMMIT_MSG==
baseline-circleci no longer applies the (deprecated) configuration resolver plugin
==COMMIT_MSG==
Possible downsides?
./gradlew resolveConfigurationsin their .circleci/config.yml, which will stop working. If they really want to continue doing this (which we don't recommend), they'll need to add it back themselves.