Adds a validator check when creating a field #298
Conversation
When doing *Field(*args, validators=[DummyValidator]), there is no check on the callable received (DummyValidator). For builtin validators, if this is not an instance, you get an incomprehensible error from _run_validation_chain. This commit adds a check at field's initialization time to ensure either a callable instance object or a function has been given as a validator by raising a meaningful error message.
| @@ -154,6 +157,14 @@ def __call__(self, **kwargs): | |||
| """ | |||
| return self.meta.render_field(self, kwargs) | |||
|
|
|||
| @classmethod | |||
There was a problem hiding this comment.
classmethod decorator needed to be able to perform a check even when instantiating an unbounded Field (access through field_class)
|
I like this idea, if you can fix the merge conflict and match the project code style (i.e. use |
| @@ -154,6 +157,14 @@ def __call__(self, **kwargs): | |||
| """ | |||
| return self.meta.render_field(self, kwargs) | |||
|
|
|||
| @classmethod | |||
| def checkValidators(cls, validators): | |||
There was a problem hiding this comment.
Use snake_case names: check_validators.
| @classmethod | ||
| def checkValidators(cls, validators): | ||
| if validators is not None: | ||
| for validator in list(validators): |
| def checkValidators(cls, validators): | ||
| if validators is not None: | ||
| for validator in list(validators): | ||
| if inspect.isclass(validator) or not hasattr(validator, '__call__'): |
There was a problem hiding this comment.
if callable(validator) and not inspect.isclass(validator):`
There was a problem hiding this comment.
Perhaps also split these checks and have different messages: "{} is not a valid validator because it is not callable." and "{} is not a valid validator because it is a class, it should be an instance."
|
I've completed the requested changes in a new PR #410 which I've merged |
When doing
*Field(*args, validators=[DummyValidator]), there is no checkon the callable received (
DummyValidator). For builtin validators, ifthis is not an instance, you get an incomprehensible error from
_run_validation_chain. This commit adds a check at field'sinitialization time to ensure either a callable instance object or a
function has been given as a validator by raising a meaningful error
message.