Validators are checked to see if they are callable and not a class #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing *Field(*args, validators=[DummyValidator]), there is no check on the callable received (DummyValidator). For builtin validators, if this is not an instance, you get an incomprehensible error from _run_validation_chain. This commit adds a check at field's initialization time to ensure either a callable instance object or a function has been given as a validator by raising a meaningful error message.
azmeuk
added a commit
to azmeuk/wtforms
that referenced
this pull request
Apr 18, 2020
azmeuk
added a commit
to azmeuk/wtforms
that referenced
this pull request
Apr 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #298, this implements the requested changes in the PR.