Backported fixes from branch master to branch 2.2-maintenance

[azmeuk]

As it was discussed on the discord, I listed the fixes that are present in the master branch and can safely be backported to branch 2.2-maintenance so we could hopefully cut a new 2.* release.

You can see the list of backports in the commit log.

I did not backport:

• IntegerField should check type when process data #451, SelectFields can now skip choice validation #493, Shortcut syntax for choices with same label & data #526 because they are more features than bugfixes
• Replaced get/setattr in test_widgets with regular accesses #484, enable flake8 #423, move to src directory #424, Edit tests quick fixes #420, Pep8 line checks typo #418, add black support #415, Test widgets #422 because they are more refactoring than bugfixes
• Added HTML5 field documentation #409 because it is just about documentation of HTML5 fields
• Setup requires Babel 2.6.0 or greater #430 because I do not understand the need for babel > 2.6.0
• use MarkupSafe for escaping #400, fix for ipv6 validator #403, Escape label unsafe chars #375, use email_validator library for Email validator instead of regex #429 because they require new dependencies (ipaddress and markupsafe)
• StringField shouldn't blank data during process_formdata. #355 because of this comment

I did backport #389 but I am not totally confident because of this docstring:
https://github.com/wtforms/wtforms/blob/df892b87365f4a62cab33c98f49ed84660bd18e6/src/wtforms/widgets/core.py#L49-L54

[davidism]

I think some of the PRs you didn't backport are appropriate for a 2.3 release. Anything that doesn't break existing behavior and just adds a feature is fine.

• IntegerField should check type when process data #451
• SelectFields can now skip choice validation #493
• Shortcut syntax for choices with same label & data #526
• Added HTML5 field documentation #409 probably unless it's not relevant to 2.x
• use MarkupSafe for escaping #400
• fix for ipv6 validator #403
• Escape label unsafe chars #375
• use email_validator library for Email validator instead of regex #429

[azmeuk]

Done.

[davidism]

I'm not going to review this since it's just backports of things we already merged. Changelog looks good. Not sure if you're keeping this open for more backports, but it's good to go whenever you're ready.

[azmeuk]

Yep, no need to review in details. I am confident with the backports being accurate. This was just about knowing what to backport or not.

[Jason-Crowe]

#400 says it is not backwards compatible, backporting this broke airflow 1.10.10 setups

apache/airflow#8512
dpgaspar/Flask-AppBuilder#1356
#581

[kaxil]

@azmeuk Is it possible to restore HTMLString and cut 2.3.1 since it specifically said it was a backwards incompatible change in the PR?

[azmeuk]

@kaxil I cannot cut a release myself but hopefully another maintainer will take care of it soon :)

[kaxil]

@kaxil I cannot cut a release myself but hopefully another maintainer will take care of it soon :)

Thanks 🤞