BUG: fix incorrect bin labels from cut when labels=False and NA prese…

…nt. close #1511
pandas-dev · Jun 28, 2012 · 0a96304 · 0a96304
1 parent d8a0b4f
commit 0a96304
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/pandas/tools/tests/test_tile.py b/pandas/tools/tests/test_tile.py
@@ -60,6 +60,12 @@ def test_cut_corner(self):
 
         self.assertRaises(ValueError, cut, [1, 2, 3], 0.5)
 
+    def test_cut_out_of_range_more(self):
+        # #1511
+        s = Series([0, -1, 0, 1, -3])
+        ind = cut(s, [0, 1], labels=False)
+        exp = [np.nan, np.nan, np.nan, 0, np.nan]
+        assert_almost_equal(ind, exp)
 
     def test_labels(self):
         arr = np.tile(np.arange(0, 1.01, 0.1), 4)

diff --git a/pandas/tools/tile.py b/pandas/tools/tile.py
@@ -180,7 +180,7 @@ def _bins_to_cuts(x, bins, right=True, labels=None, retbins=False,
     else:
         fac = ids - 1
         if has_nas:
-            fac = ids.astype(np.float64)
+            fac = fac.astype(np.float64)
             np.putmask(fac, na_mask, np.nan)
 
     if not retbins: