Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Behavior of cut when labels=False #1511

Closed
dalejung opened this issue Jun 22, 2012 · 1 comment
Closed

Inconsistent Behavior of cut when labels=False #1511

dalejung opened this issue Jun 22, 2012 · 1 comment
Labels
Milestone

Comments

@dalejung
Copy link
Contributor

s = Series([0, -1, 0, 1, -3])
ind, label = cut(s, [-4, 0, 1], retbins=True, labels=False)
# label [-4  0  1]
# ind array([0, 0, 0, 1, 0])

s = Series([0, -1, 0, 1, -3])
ind, label = cut(s, [0, 1], retbins=True, labels=False)
# label [0 1]
# ind array([ nan,  nan,  nan,   1.,  nan]) 
# Should the 1 be a 0?

I recall that there always used to be an implicit out of range level. It seems like the second example still acts like the (-inf, 0] exists.

I could test the ind for nan to handle this, but wanted to make sure it wasn't a bug.

@wesm
Copy link
Member

wesm commented Jun 28, 2012

Thanks for catching this bug, indeed was caused by a typo and insufficient test coverage. Pushing a fix shortly

@wesm wesm closed this as completed in 0a96304 Jun 28, 2012
yarikoptic added a commit to neurodebian/pandas that referenced this issue Jun 30, 2012
Version 0.8.0

* tag 'v0.8.0': (21 commits)
  RLS: version 0.8.0
  DOC: release notes
  BUG: _get_marker_compat insufficient on matplotlib < 1.1.0
  BUG: don't use local() in read_* functions, breaks sys.settrace. close pandas-dev#1547
  BUG: fix Panel slice setting issue and matplotlib import issues pandas-dev#1548, pandas-dev#1533
  ENH: parsers don't use tempfile
  ENH: implement DataFrameGroupBy.boxplot(), close pandas-dev#1507
  BUG: fix MultiIndex indexing issues in pandas-dev#1537, python 2.5 api fix
  BUG: fix incorrect bin labels from cut when labels=False and NA present. close pandas-dev#1511
  ENH: support file-like objects in ExcelFile, close pandas-dev#1529
  TST: skip test raising unsortable warning on 32-bit windows, other platforms. pandas-dev#1546
  BUG: raise exceptions out of trying to parse iso8601 strings
  TST: separated test case
  BUG: custom colors for bar chart pandas-dev#1540
  ENH: add 'time' as inferred_type
  ENH: datetime.time converters for plotting
  BUG: fix MultiIndex segfault due to internal refactoring. close pandas-dev#1532
  BUG: fix MultiIndex compatibility bugs described in pandas-dev#1534 post gutting internal array close pandas-dev#1534
  BUG: parser bug when parse_dates is string pandas-dev#1544
  BUG: return nameless Series and index from from_csv
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants