-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: Positional arguments in to_* I/O methods #54229
Comments
take |
Going to mark this as a good first issue. See #41485 as a starting point for how to do this. You are basically doing the same, but for the (Please add your whatsnew to v2.2.0.rst for now. In the future, if this issue is still open after 2.2.0 comes out, pick the whatsnew corresponding to the newest release that ends in a zero. e.g. v2.3.0.rst, ...) If you need any help, please ask on Slack (#newcomers channel) to avoid cluttering up this issue, but if you'd like to take one of the methods, just comment which one you want below. |
I'll take |
Taking |
taking |
@mroeschke @lithomas1 can one of you please review this #54599 |
I have a PR opened for |
Hey @rmhowe425 , I took some of the other methods. Would it be okay if I help out with the ones I already selected? Also do you plan to work on all the methods by yourself? |
@rsm-23 Feel free to tackle any and all methods excluding |
@rmhowe425 If you'd like something else to work on, I can go and look at/breakdown some other issues. |
@rmhowe425 sorry for misreading the situation here. To resolve the situation here, I am fine with closing my PRs. You can continue to work on the whole issue. |
I think I was a bit confused as well! All good! @rsm-23 Looks like you're tackling these at lightning speed! Feel free to continue working your way down the list of methods! After my PR for |
@rsm-23 Just unassigned myself from the issue if you want to take it |
take |
|
For |
@mroeschke for |
hey @mroeschke can you please update the above checklist? Want to cross-check what else is pending? Also,
|
Yup those sound good |
@mroeschke |
These should all be keyword only except for buf/path_or_buf argument (the first one).
cc @MarcoGorelli since you championed the last effort
The text was updated successfully, but these errors were encountered: