DEPR: make arguments keyword only in to_dict #54630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsm-23
changed the title
pandas/core/frame.py
Outdated
| @@ -2005,25 +2009,25 @@ def to_dict( | |||
|
|
|||
| You can specify the return orientation. | |||
|
|
|||
| >>> df.to_dict('series') | |||
| >>> df.to_dict(orient='series') | |||
There was a problem hiding this comment.
We could also keep allowing just orient as positional only keyword, given how we have been using that ourselves in the docs?
There was a problem hiding this comment.
Sure, should I make that change then?
There was a problem hiding this comment.
@jorisvandenbossche should I remove the keyword orient from the examples and tests as well?
|
@mroeschke should I remove the |
|
Yes |
|
@jorisvandenbossche @mroeschke I am done with the changes. |
mroeschke
approved these changes
Aug 22, 2023
|
Thanks @rsm-23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v2.2.0.rstfile if fixing a bug or adding a new feature.