Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Remove the engine parameter in CSVFormatter and to_csv #13419

Closed

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Jun 10, 2016

Title is self-explanatory.

Internal code and #6581 indicate that this was long overdue.

@@ -40,6 +40,8 @@ Other enhancements
Backwards incompatible API changes
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

- ``DataFrame.to_csv()`` has dropped the ``engine`` parameter (:issue:`13419`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to "Removal of prior version deprecations/changes" (a bit below)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch. Fixed.

@jorisvandenbossche jorisvandenbossche added this to the 0.19.0 milestone Jun 10, 2016
@jorisvandenbossche jorisvandenbossche added IO CSV read_csv, to_csv Deprecate Functionality to remove in pandas labels Jun 10, 2016
@gfyoung gfyoung force-pushed the to-csv-engine-param-remove branch from 2677cc2 to b03e148 Compare June 10, 2016 11:13
@@ -64,6 +64,7 @@ Deprecations
Removal of prior version deprecations/changes
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

- ``DataFrame.to_csv()`` has dropped the ``engine`` parameter (:issue:`13419`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put the original issue number here (you can leave this one as well if you want).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing. Done.

@jreback
Copy link
Contributor

jreback commented Jun 10, 2016

see #11274 this was actually just deprecated in 0.17.1 (even though it said 0.13).

@gfyoung gfyoung force-pushed the to-csv-engine-param-remove branch 6 times, most recently from 5b0851c to 36e4f42 Compare June 17, 2016 03:57
@gfyoung gfyoung force-pushed the to-csv-engine-param-remove branch 11 times, most recently from 3743721 to 489f2c0 Compare June 24, 2016 13:33
@gfyoung gfyoung force-pushed the to-csv-engine-param-remove branch 5 times, most recently from 1508d9c to 7bd4856 Compare July 1, 2016 01:07
@gfyoung gfyoung force-pushed the to-csv-engine-param-remove branch 7 times, most recently from de7c13b to 16a3264 Compare July 8, 2016 00:00
@jorisvandenbossche
Copy link
Member

@gfyoung Master is now targeted for 0.19.0, so this can go in. Can you move the whatsnew note to the correct file?

@jorisvandenbossche jorisvandenbossche modified the milestones: 0.19.0, 0.20.0 Jul 8, 2016
@gfyoung gfyoung force-pushed the to-csv-engine-param-remove branch from 16a3264 to ab0fa11 Compare July 8, 2016 15:29
@codecov-io
Copy link

codecov-io commented Jul 8, 2016

Current coverage is 84.32%

Merging #13419 into master will increase coverage by 0.01%

@@             master     #13419   diff @@
==========================================
  Files           138        138          
  Lines         51157      51083    -74   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43131      43076    -55   
+ Misses         8026       8007    -19   
  Partials          0          0          

Powered by Codecov. Last updated by 5701c69...ddd6cd2

@gfyoung
Copy link
Member Author

gfyoung commented Jul 8, 2016

@jreback , @jorisvandenbossche : Travis is passing, so ready to merge if there are no other concerns.

@gfyoung gfyoung force-pushed the to-csv-engine-param-remove branch from ab0fa11 to ddd6cd2 Compare July 9, 2016 19:42
@jreback
Copy link
Contributor

jreback commented Jul 9, 2016

lgtm. ping on green.

@gfyoung
Copy link
Member Author

gfyoung commented Jul 10, 2016

@jreback : Travis is giving the green light. Ready to merge if there are no other concerns.

@jreback
Copy link
Contributor

jreback commented Jul 10, 2016

@gfyoung yes, merging shortly.

@jreback jreback closed this in c989570 Jul 10, 2016
@jreback
Copy link
Contributor

jreback commented Jul 10, 2016

thanks @gfyoung

@gfyoung gfyoung deleted the to-csv-engine-param-remove branch July 10, 2016 21:52
nateGeorge pushed a commit to nateGeorge/pandas that referenced this pull request Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants