BUG: select_as_multiple doesn't respect start/stop kwargs GH16209 #16317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16317 +/- ##
==========================================
- Coverage 90.39% 90.37% -0.02%
==========================================
Files 161 161
Lines 50863 50863
==========================================
- Hits 45978 45969 -9
- Misses 4885 4894 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #16317 +/- ##
==========================================
+ Coverage 90.39% 90.75% +0.35%
==========================================
Files 161 161
Lines 50863 51071 +208
==========================================
+ Hits 45978 46349 +371
+ Misses 4885 4722 -163
Continue to review full report at Codecov.
|
jreback
reviewed
May 10, 2017
| @@ -4186,6 +4186,20 @@ def test_start_stop_table(self): | |||
| expected = df.loc[30:40, ['A']] | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| def test_start_stop_multiple(self): | |||
|
|
|||
There was a problem hiding this comment.
can you add the issue number as a comment
There was a problem hiding this comment.
can you add the issue number
jreback
reviewed
May 10, 2017
pandas/tests/io/test_pytables.py
Outdated
| result = store.select_as_multiple(['selector', 'data'], | ||
| selector='selector', start=0, | ||
| stop=1) | ||
| expected = df[['foo', 'bar']].iloc[[0]] |
There was a problem hiding this comment.
df.loc[[0], ['foo', 'bar']] is more idiomatic
jreback
reviewed
May 10, 2017
doc/source/whatsnew/v0.21.0.txt
Outdated
| @@ -82,6 +82,7 @@ Indexing | |||
| I/O | |||
| ^^^ | |||
|
|
|||
| - Bug in ``HDFStore.select_as_multiple()`` where start/stop arguments were not respected (:issue:`16209`) | |||
There was a problem hiding this comment.
you can put this in 0.20.2
|
minor comments, lgtm. ping on green. |
|
@JosephWagner if you can update according to Jeff's comments we can get this in for 0.20.2 (end of the week). OK to leave for 0.21.0 though. |
|
this lgtm. Though if you can update to comments can merge for 0.20.2. |
|
Sorry for the late response. I've updated the PR as specified. Let me know if more changes are needed! |
|
thanks! |
TomAugspurger
pushed a commit
to TomAugspurger/pandas
that referenced
this pull request
Jun 1, 2017
…ndas-dev#16317) (cherry picked from commit 03d44f3)
Kiv
pushed a commit
to Kiv/pandas
that referenced
this pull request
Jun 11, 2017
stangirala
pushed a commit
to stangirala/pandas
that referenced
this pull request
Jun 11, 2017
yarikoptic
added a commit
to neurodebian/pandas
that referenced
this pull request
Jul 12, 2017
Version 0.20.2 * tag 'v0.20.2': (68 commits) RLS: v0.20.2 DOC: Update release.rst DOC: Whatsnew fixups (pandas-dev#16596) ERRR: Raise error in usecols when column doesn't exist but length matches (pandas-dev#16460) BUG: convert numpy strings in index names in HDF pandas-dev#13492 (pandas-dev#16444) PERF: vectorize _interp_limit (pandas-dev#16592) DOC: whatsnew 0.20.2 edits (pandas-dev#16587) API: Make is_strictly_monotonic_* private (pandas-dev#16576) BUG: reimplement MultiIndex.remove_unused_levels (pandas-dev#16565) Strictly monotonic (pandas-dev#16555) ENH: add .ngroup() method to groupby objects (pandas-dev#14026) (pandas-dev#14026) fix linting BUG: Incorrect handling of rolling.cov with offset window (pandas-dev#16244) BUG: select_as_multiple doesn't respect start/stop kwargs GH16209 (pandas-dev#16317) return empty MultiIndex for symmetrical difference on equal MultiIndexes (pandas-dev#16486) BUG: Bug in .resample() and .groupby() when aggregating on integers (pandas-dev#16549) BUG: Fixed tput output on windows (pandas-dev#16496) Strictly monotonic (pandas-dev#16555) BUG: fixed wrong order of ordered labels in pd.cut() BUG: Fixed to_html ignoring index_names parameter ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master --name-only -- '*.py' | flake8 --diff