BUG: Fixed tput output on windows #16496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
added
Output-Formatting
Codecov Report
@@ Coverage Diff @@
## master #16496 +/- ##
==========================================
- Coverage 90.43% 90.38% -0.05%
==========================================
Files 161 161
Lines 51045 51049 +4
==========================================
- Hits 46161 46140 -21
- Misses 4884 4909 +25
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #16496 +/- ##
==========================================
- Coverage 90.43% 90.38% -0.05%
==========================================
Files 161 161
Lines 51045 51049 +4
==========================================
- Hits 46161 46140 -21
- Misses 4884 4909 +25
Continue to review full report at Codecov.
|
|
Any thoughts on this @jreback? I don't think it should break anything. |
|
lgtm. |
TomAugspurger
added a commit
to TomAugspurger/pandas
that referenced
this pull request
Jun 1, 2017
(cherry picked from commit 7efc4e8)
TomAugspurger
added a commit
that referenced
this pull request
Jun 4, 2017
(cherry picked from commit 7efc4e8)
Kiv
pushed a commit
to Kiv/pandas
that referenced
this pull request
Jun 11, 2017
stangirala
pushed a commit
to stangirala/pandas
that referenced
this pull request
Jun 11, 2017
yarikoptic
added a commit
to neurodebian/pandas
that referenced
this pull request
Jul 12, 2017
Version 0.20.2 * tag 'v0.20.2': (68 commits) RLS: v0.20.2 DOC: Update release.rst DOC: Whatsnew fixups (pandas-dev#16596) ERRR: Raise error in usecols when column doesn't exist but length matches (pandas-dev#16460) BUG: convert numpy strings in index names in HDF pandas-dev#13492 (pandas-dev#16444) PERF: vectorize _interp_limit (pandas-dev#16592) DOC: whatsnew 0.20.2 edits (pandas-dev#16587) API: Make is_strictly_monotonic_* private (pandas-dev#16576) BUG: reimplement MultiIndex.remove_unused_levels (pandas-dev#16565) Strictly monotonic (pandas-dev#16555) ENH: add .ngroup() method to groupby objects (pandas-dev#14026) (pandas-dev#14026) fix linting BUG: Incorrect handling of rolling.cov with offset window (pandas-dev#16244) BUG: select_as_multiple doesn't respect start/stop kwargs GH16209 (pandas-dev#16317) return empty MultiIndex for symmetrical difference on equal MultiIndexes (pandas-dev#16486) BUG: Bug in .resample() and .groupby() when aggregating on integers (pandas-dev#16549) BUG: Fixed tput output on windows (pandas-dev#16496) Strictly monotonic (pandas-dev#16555) BUG: fixed wrong order of ordered labels in pd.cut() BUG: Fixed to_html ignoring index_names parameter ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in dask. For reasons I don't understand, you can end up with a bunch of warnings like
tput: terminal attributes: No such device or addresswhen pandas callsget_terminal_sizeI was able to monkey patch those calls with
shutil.get_terminal_sizeand verify that the warnings were fixed. However that's python3 only. This change usesshutil.get_terminal_sizewhen possible, and falls back to our prior implementation otherwise.Not sure about unit tests, but manually, the output matches on my mac.