CLN: Use pandas.core.common for None checks #17816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17816 +/- ##
==========================================
- Coverage 91.26% 91.25% -0.01%
==========================================
Files 163 163
Lines 49978 49981 +3
==========================================
- Hits 45611 45609 -2
- Misses 4367 4372 +5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #17816 +/- ##
==========================================
- Coverage 91.26% 91.25% -0.01%
==========================================
Files 163 163
Lines 49978 49981 +3
==========================================
- Hits 45611 45609 -2
- Misses 4367 4372 +5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #17816 +/- ##
==========================================
- Coverage 91.25% 91.21% -0.04%
==========================================
Files 163 163
Lines 50038 50041 +3
==========================================
- Hits 45661 45647 -14
- Misses 4377 4394 +17
Continue to review full report at Codecov.
|
jreback
requested changes
Oct 8, 2017
pandas/core/common.py
Outdated
| for arg in args: | ||
| if arg is not None: | ||
| return False | ||
| return True |
There was a problem hiding this comment.
can you add a 1-liner doc-string to these, otherwise lgtm.
jschendel
force-pushed
the
cln-check-none
branch
from
2572d95
to
a1f3279
Compare
jschendel
force-pushed
the
cln-check-none
branch
from
a1f3279
to
9599722
Compare
jreback
approved these changes
Oct 13, 2017
|
thanks! this helps make things consistent. Ideally I think we could expand the dev docs to give a little color on where things are (e.g. we have lots of utilities, but not always easily discovered). if you would want to do some docs would be fantastic. |
buntwo
pushed a commit
to buntwo/pandas
that referenced
this pull request
Oct 14, 2017
ghost
pushed a commit
to reef-technologies/pandas
that referenced
this pull request
Oct 16, 2017
ghost
pushed a commit
to reef-technologies/pandas
that referenced
this pull request
Oct 16, 2017
* upstream/master: (76 commits) CategoricalDtype construction: actually use fastpath (pandas-dev#17891) DEPR: Deprecate tupleize_cols in to_csv (pandas-dev#17877) BUG: Fix wrong column selection in drop_duplicates when duplicate column names (pandas-dev#17879) DOC: Adding examples to update docstring (pandas-dev#16812) (pandas-dev#17859) TST: Skip if no openpyxl in test_excel (pandas-dev#17883) TST: Catch read_html slow test warning (pandas-dev#17874) flake8 cleanup (pandas-dev#17873) TST: remove moar warnings (pandas-dev#17872) ENH: tolerance now takes list-like argument for reindex and get_indexer. (pandas-dev#17367) ERR: Raise ValueError when week is passed in to_datetime format witho… (pandas-dev#17819) TST: remove some deprecation warnings (pandas-dev#17870) Refactor index-as-string groupby tests and fix spurious warning (Bug 17383) (pandas-dev#17843) BUG: merging with a boolean/int categorical column (pandas-dev#17841) DEPR: Deprecate read_csv arguments fully (pandas-dev#17865) BUG: to_json - prevent various segfault conditions (GH14256) (pandas-dev#17857) CLN: Use pandas.core.common for None checks (pandas-dev#17816) BUG: set tz on DTI from fixed format HDFStore (pandas-dev#17844) RLS: v0.21.0rc1 Whatsnew cleanup (pandas-dev#17858) DEPR: Deprecate the convert parameter completely (pandas-dev#17831) ...
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffUsed
Nonechecking functions frompandas.core.commonwhere applicable. Common patterns changed:all(v is not None for v in values)->_all_not_none(*values)*for argument unpacking in many cases, not sure if that's frowned upon.a is not None and b is not None and c is not None->_all_not_none(a, b, c)None. Left checks of 2 as-is.Also created an
any_not_nonefunction similar to the other three that exist. I suppose the is equivalent tonot all_none(...), but I feel like usingany_not_noneis more readable and indicative of intent.