Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Deprecate read_csv arguments fully #17865

Merged
merged 1 commit into from
Oct 14, 2017

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Oct 13, 2017

Issue warnings on read_csv deprecated args
in full, even if the normal defaults were passed in.

Closes #17828.

@gfyoung gfyoung added Deprecate Functionality to remove in pandas IO CSV read_csv, to_csv labels Oct 13, 2017
@gfyoung gfyoung added this to the 0.21.0 milestone Oct 13, 2017
@gfyoung
Copy link
Member Author

gfyoung commented Oct 13, 2017

No whatsnew is needed because all of these arguments were already deprecated.

Issue warnings on `read_csv` deprecated args
in full, even if the normal defaults were passed in.

Closes pandas-devgh-17828.
@codecov
Copy link

codecov bot commented Oct 14, 2017

Codecov Report

Merging #17865 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17865      +/-   ##
==========================================
- Coverage   91.23%   91.22%   -0.02%     
==========================================
  Files         163      163              
  Lines       50075    50080       +5     
==========================================
- Hits        45688    45684       -4     
- Misses       4387     4396       +9
Flag Coverage Δ
#multiple 89.03% <100%> (ø) ⬆️
#single 40.3% <57.14%> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/core/frame.py 97.75% <ø> (-0.1%) ⬇️
pandas/io/parsers.py 95.51% <100%> (+0.01%) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c964a4...36fbc41. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Oct 14, 2017

@gfyoung lgtm.

@jreback jreback merged commit b594137 into pandas-dev:master Oct 14, 2017
@jreback
Copy link
Contributor

jreback commented Oct 14, 2017

@gfyoung lots of warnings from other uses of read_csv with tupleize (read_html I think): https://travis-ci.org/pandas-dev/pandas/jobs/287943551

can you do a PR to fix

@gfyoung gfyoung deleted the read-csv-arg-depr-full branch October 14, 2017 18:07
gfyoung added a commit to forking-repos/pandas that referenced this pull request Oct 14, 2017
gfyoung added a commit that referenced this pull request Oct 15, 2017
ghost pushed a commit to reef-technologies/pandas that referenced this pull request Oct 16, 2017
Issue warnings on `read_csv` deprecated args
in full, even if the normal defaults were passed in.

Closes pandas-devgh-17828.
ghost pushed a commit to reef-technologies/pandas that referenced this pull request Oct 16, 2017
ghost pushed a commit to reef-technologies/pandas that referenced this pull request Oct 16, 2017
* upstream/master: (76 commits)
  CategoricalDtype construction: actually use fastpath (pandas-dev#17891)
  DEPR: Deprecate tupleize_cols in to_csv (pandas-dev#17877)
  BUG: Fix wrong column selection in drop_duplicates when duplicate column names (pandas-dev#17879)
  DOC: Adding examples to update docstring (pandas-dev#16812) (pandas-dev#17859)
  TST: Skip if no openpyxl in test_excel (pandas-dev#17883)
  TST: Catch read_html slow test warning (pandas-dev#17874)
  flake8 cleanup (pandas-dev#17873)
  TST: remove moar warnings (pandas-dev#17872)
  ENH: tolerance now takes list-like argument for reindex and get_indexer. (pandas-dev#17367)
  ERR: Raise ValueError when week is passed in to_datetime format witho… (pandas-dev#17819)
  TST: remove some deprecation warnings (pandas-dev#17870)
  Refactor index-as-string groupby tests and fix spurious warning (Bug 17383) (pandas-dev#17843)
  BUG: merging with a boolean/int categorical column (pandas-dev#17841)
  DEPR: Deprecate read_csv arguments fully (pandas-dev#17865)
  BUG: to_json - prevent various segfault conditions (GH14256) (pandas-dev#17857)
  CLN: Use pandas.core.common for None checks (pandas-dev#17816)
  BUG: set tz on DTI from fixed format HDFStore (pandas-dev#17844)
  RLS: v0.21.0rc1
  Whatsnew cleanup (pandas-dev#17858)
  DEPR: Deprecate the convert parameter completely (pandas-dev#17831)
  ...
yeemey pushed a commit to yeemey/pandas that referenced this pull request Oct 20, 2017
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
Issue warnings on `read_csv` deprecated args
in full, even if the normal defaults were passed in.

Closes pandas-devgh-17828.
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Issue warnings on `read_csv` deprecated args
in full, even if the normal defaults were passed in.

Closes pandas-devgh-17828.
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants