ENH: Return locale based month_name and weekday_name values (#12805, #12806) #18164

mroeschke · 2017-11-08T04:29:11Z

tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

I am not sure what locales are available on the CI machines, but the test will run all available locales.

jreback · 2017-11-08T11:00:55Z

need to add month_name to nat docstrings generation

jreback · 2017-11-08T11:03:27Z

doc/source/whatsnew/v0.21.1.txt

-
-
+- :attr:`Timestamp.month_name`, :attr:`DatetimeIndex.month_name`, and :attr:`Series.dt.month_name` are now available (:issue:`12805`)
+- ``month_name` and ``weekday_name`` attributes will now return locale aware values (:issue:`12806`)


move the 2nd point to bug fix; only mention weekday_name and use attr (as u did for month_name)

jreback · 2017-11-08T11:08:42Z

pandas/tests/indexes/datetimes/test_misc.py

-
+    # GH 12806
+    @pytest.mark.parametrize('time_locale', tm.get_locales())
+    def test_datetimeindex_accessors(self, time_locale):


can u split out the month_name and weekday_name to a separate test
skip if number of locales is 0

can then check that we don’t skip on build where we should have a locales defined

mroeschke · 2017-11-09T07:28:13Z

Added month_name as a property to NaT, moved whatsnew updates, and moved name accessor tests to their own function with a skip if no locales are available.

jreback · 2017-11-09T13:16:21Z

doc/source/whatsnew/v0.21.1.txt

@@ -22,7 +22,7 @@ Other Enhancements
 ^^^^^^^^^^^^^^^^^^

 - :meth:`Timestamp.timestamp` is now available in Python 2.7. (:issue:`17329`)
-
+- :attr:`Timestamp.month_name`, :attr:`DatetimeIndex.month_name`, and :attr:`Series.dt.month_name` are now available (:issue:`12805`)


actually move these to 0.22, we can't backport this as you are using some of the new timeseries stuff

codecov · 2017-11-10T03:32:52Z

Codecov Report

Merging #18164 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #18164      +/-   ##
==========================================
+ Coverage    91.4%    91.4%   +<.01%     
==========================================
  Files         163      163              
  Lines       50064    50069       +5     
==========================================
+ Hits        45759    45768       +9     
+ Misses       4305     4301       -4

Flag	Coverage Δ
#multiple	`89.21% <100%> (+0.02%)`	⬆️
#single	`40.39% <100%> (-0.04%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/indexes/datetimes.py	`95.48% <100%> (+0.1%)`	⬆️
pandas/io/gbq.py	`25% <0%> (-58.34%)`	⬇️
pandas/core/frame.py	`97.8% <0%> (-0.1%)`	⬇️
pandas/io/formats/format.py	`96.01% <0%> (ø)`	⬆️
pandas/core/generic.py	`95.72% <0%> (ø)`	⬆️
pandas/core/config_init.py	`98.34% <0%> (ø)`	⬆️
pandas/core/groupby.py	`92.04% <0%> (+0.01%)`	⬆️
pandas/plotting/_converter.py	`65.2% <0%> (+1.81%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca737ac...6f39578. Read the comment docs.

codecov · 2017-11-10T03:32:52Z

Codecov Report

Merging #18164 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #18164      +/-   ##
==========================================
+ Coverage   91.69%   91.69%   +<.01%     
==========================================
  Files         150      150              
  Lines       49043    48997      -46     
==========================================
- Hits        44968    44929      -39     
+ Misses       4075     4068       -7

Flag	Coverage Δ
#multiple	`90.07% <100%> (ø)`	⬆️
#single	`41.94% <12.5%> (+0.12%)`	⬆️

Impacted Files	Coverage Δ
pandas/core/indexes/datetimes.py	`95.57% <100%> (-0.02%)`	⬇️
pandas/core/indexes/base.py	`96.45% <0%> (-0.22%)`	⬇️
pandas/core/internals.py	`95.53% <0%> (-0.01%)`	⬇️
pandas/io/formats/format.py	`96.25% <0%> (-0.01%)`	⬇️
pandas/core/generic.py	`95.88% <0%> (-0.01%)`	⬇️
pandas/core/config_init.py	`100% <0%> (ø)`	⬆️
pandas/core/indexes/range.py	`95.7% <0%> (ø)`	⬆️
pandas/core/groupby.py	`92.31% <0%> (+0.17%)`	⬆️
pandas/io/formats/style.py	`96.22% <0%> (+0.18%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f271eb...d97f43b. Read the comment docs.

jorisvandenbossche · 2017-11-10T09:37:58Z

doc/source/whatsnew/v0.22.0.txt

@@ -94,7 +94,7 @@ Bug Fixes
 Conversion
 ^^^^^^^^^^

-
+- Bug in :attr:`Timestamp.weekday_name` and :attr:`DatetimeIndex.weekday_name` not returning locale aware values (:issue:`12806`)


I don't think we should this as a bug, it is rather an API change as we deliberately returned non-locale dependent values.

(and to be honest, I am also not sure that I really like locale-dependent return values)

we could add an additonal accessor, e.g. weekday_name_for_locale? (hate adding things, but I agree that this might not be only desirable in some cases).

We could turn weekday_name and month_name into functions that can accept a locale argument and default it to 'en_US.UTF8'? I think that would be clean, but it would definitely be an API change.

hmm, that's an idea. we could could make new ones weekday_names() (and then just deprecate weekday_name

jorisvandenbossche · 2017-11-10T16:20:30Z

@mroeschke We could turn weekday_name and month_name into functions that can accept a locale argument and default it to 'en_US.UTF8'? I think that would be clean, but it would definitely be an API change.

@jreback hmm, that's an idea. we could could make new ones weekday_names() (and then just deprecate weekday_name

That's an option. Another option is to leave it as is but to clearly document in those attributes how to get your locale dependent names. Eg it would be nice that the following would work:

In [26]: import calendar

In [27]: dt = pd.date_range('2016-01-01', periods=10, freq='10D')

In [28]: dt.weekday
Out[28]: Int64Index([4, 0, 3, 6, 2, 5, 1, 4, 0, 3], dtype='int64')

In [29]: dt.weekday.map(calendar.day_name)
...
TypeError: '_localized_day' object is not callable

(the problem here is that calendar.day_name is some kind of mapping (it has __getitem__) but not really)

This works:

In [32]: pd.Series(dt.weekday).map({i: calendar.day_name[i] for i in range(7)})
Out[32]: 
0       Friday
1       Monday
2     Thursday
3       Sunday
4    Wednesday
5     Saturday
6      Tuesday
7       Friday
8       Monday
9     Thursday
dtype: object

(second issue is that Index.map apparently does not work with dict, while Series.map does)

But I think both issues could be solved to make this easier.

jorisvandenbossche · 2017-11-10T16:23:58Z

(On the other hand, such a pointer in the docstring is certainly less discoverable than a month_name method, I just in doubt this is worth it adding yet another method ..)

jorisvandenbossche · 2017-11-10T16:26:20Z

Index.map dict issue is reported here: #13517

mroeschke · 2017-11-10T18:20:04Z

I'll summarize the proposals and add an additional one:

Default to the user's system's locale (this PR)
Create a new function (would personally prefer .day_name(locale='en_US.UTF8') harmonizing with calendar.day_name)
Default to English locale and enhance the docs with a locale recipe
Utilize pandas.set_option and add something like mode.time_locale, defaulting to the English locale.

I think 4) would be a nice option to maintain the existing behavior and minimize altering existing methods. Otherwise I think I'd prefer 3) over 2) (I realize the Pandas API is already large).

What do you guys think @jreback @jorisvandenbossche?

jreback · 2017-11-10T19:02:05Z

so I actually like renaming weekday_name -> day_name regardless here for consistency.

is interesting

I wonder how common the need to look things up in different locales is, if its not that common (guess), then this makes sense

appeals as well (talking about the argument for the locale in the function call)

mroeschke · 2017-11-20T19:51:29Z

I decided to implement a day_name(time_locale=None) and month_name(time_locale=None) method that can accept a locale argument. Wanted to run the implementation by you guys.

Also, should I got ahead and also depreciate the .weekday_name attribute in this PR?

jreback · 2017-11-23T16:34:24Z

I decided to implement a day_name(time_locale=None) and month_name(time_locale=None) method that can accept a locale argument. Wanted to run the implementation by you guys.

that sounds good

Also, should I got ahead and also depreciate the .weekday_name attribute in this PR?

yes this is also ok

mroeschke · 2018-01-12T06:09:51Z

Sorry for being idle on this PR. Rebased, and added the day_name() and month_name() methods to Timestamp and DatetimeIndex

jreback

can you also deprecate weekday_name (in favor of day_name)

jreback · 2018-01-12T11:54:08Z

pandas/_libs/tslibs/fields.pyx


    count = len(dtindex)
    out = np.empty(count, dtype=object)

    if field == 'weekday_name':
+        _dayname = np.array(['Monday', 'Tuesday', 'Wednesday', 'Thursday',


move (and import from) ccalendar

jreback · 2018-01-12T11:54:53Z

pandas/_libs/tslibs/fields.pyx

+                                 'friday', 'saturday', 'sunday'],
+                                dtype=np.object_)
+        else:
+            with set_locale(time_locale, locale.LC_TIME):


this function (the locale conversion of the names) should be in ccalandar.pyx
just have a function which takes the locale (default None), so this is much simpler here

jreback · 2018-01-12T11:56:02Z

pandas/_libs/tslibs/nattype.pyx

@@ -320,7 +325,32 @@ class NaTType(_NaT):
    # nan methods
    weekday = _make_nan_func('weekday', datetime)
    isoweekday = _make_nan_func('isoweekday', datetime)
+    month_name = _make_nan_func('month_name',  # noqa:E128
+        """


make this a named parameter

jreback · 2018-01-12T11:56:27Z

pandas/_libs/tslibs/nattype.pyx

@@ -42,8 +42,13 @@ _nat_scalar_rules[Py_GE] = False
 def _make_nan_func(func_name, cls):


make doc an optional parameter doc

mroeschke · 2018-01-13T06:40:33Z

Created get_locale_names in ccalendar.pyx that provides localized day and month names, _make_missing_value_func to replace _make_nan_func and _make_nat_func, and added deprecation to weekday_name

Although, I am not sure how to add a deprecation warning to DatetimeIndex.weekday_name since the method is pre-generated with _field_accessor

jreback

need tests that catch the deprecation warning

jreback · 2018-01-13T12:48:12Z

pandas/_libs/tslibs/timestamps.pyx

    @property
    def weekday_name(self):
+        """
+        .. depreciated:: 0.23.0


jreback · 2018-01-13T12:50:43Z

pandas/tests/indexes/datetimes/test_misc.py

@@ -342,6 +327,37 @@ def test_datetimeindex_accessors(self):
        assert dates.weekofyear.tolist() == expected
        assert [d.weekofyear for d in dates] == expected

+    # GH 12806
+    @pytest.mark.skipif(not tm.get_locales(), reason='No available locales')
+    @pytest.mark.parametrize('time_locale', tm.get_locales())


this should still test for locale is None

jreback · 2018-01-13T12:51:17Z

pandas/core/indexes/datetimes.py

@@ -1686,7 +1688,7 @@ def freq(self, value):
    weekday_name = _field_accessor(
        'weekday_name',
        'weekday_name',
-        "The name of day in a week (ex: Friday)\n\n.. versionadded:: 0.18.1")
+        "The name of day in a week (ex: Friday)\n\n.. depreciated:: 0.23.0")


need to show a deprecation warning for this as well

nvm i see this below

jreback · 2018-01-13T12:51:38Z

doc/source/whatsnew/v0.23.0.txt

@@ -202,6 +202,8 @@ Other Enhancements
 - ``Resampler`` objects now have a functioning :attr:`~pandas.core.resample.Resampler.pipe` method.
  Previously, calls to ``pipe`` were diverted to  the ``mean`` method (:issue:`17905`).
 - :func:`~pandas.api.types.is_scalar` now returns ``True`` for ``DateOffset`` objects (:issue:`18943`).
+- :meth:`Timestamp.month_name`, :meth:`DatetimeIndex.month_name`, and :meth:`Series.dt.month_name` are now available (:issue:`12805`)
+- :meth:`Timestamp.day_name` and :meth:`DatetimeIndex.day_name` are now available to return day names with a specified locale (:issue:`12806`)


need an entry in Deprecated section

jreback · 2018-01-13T12:52:43Z

pandas/_libs/tslibs/ccalendar.pyx

@@ -13,6 +13,9 @@ cimport numpy as np
 from numpy cimport int64_t, int32_t
 np.import_array()

+import locale
+from pandas.util.testing import set_locale
+from strptime import LocaleTime


move these imports inside get_locale_names

jreback · 2018-01-13T12:54:56Z

pandas/_libs/tslibs/timestamps.pyx

+            days = dict(enumerate(ccalendar.DAYS_FULL))
+        else:
+            names = ccalendar.get_locale_names('f_weekday', time_locale)
+            days = dict(enumerate(names))


move the dict(enumerate after the if (eg do it once)

jreback · 2018-01-13T12:55:05Z

pandas/_libs/tslibs/timestamps.pyx

+            months = dict(enumerate(ccalendar.MONTHS_FULL))
+        else:
+            names = ccalendar.get_locale_names('f_month', time_locale)
+            months = dict(enumerate(names))


jreback · 2018-02-25T21:06:26Z

rebase on master

mroeschke · 2018-02-26T05:03:33Z

Rebased on master and addressed your comments @jreback. Looks like a travis build timed out.

jreback

can you update the test that hits Series.dt.day_name (you have to add the new methods and remove the old one), in the series tests

jreback · 2018-02-26T11:14:44Z

pandas/_libs/tslibs/ccalendar.pyx

@@ -199,3 +208,27 @@ cpdef int32_t get_day_of_year(int year, int month, int day) nogil:

    day_of_year = mo_off + day
    return day_of_year
+
+
+cpdef get_locale_names(object name_type, object time_locale=None):


only needs to be cdef unless called elsewhere

jreback · 2018-02-26T11:15:10Z

pandas/_libs/tslibs/ccalendar.pyx

+    from pandas.util.testing import set_locale
+
+    with set_locale(time_locale, locale.LC_TIME):
+        locale_names = getattr(LocaleTime(), name_type)


you can just return this directly, no need to have a variable locale_names

jreback · 2018-02-26T11:15:47Z

pandas/_libs/tslibs/fields.pyx

@@ -85,7 +85,8 @@ def build_field_sarray(ndarray[int64_t] dtindex):

 @cython.wraparound(False)
 @cython.boundscheck(False)
-def get_date_name_field(ndarray[int64_t] dtindex, object field):
+def get_date_name_field(ndarray[int64_t] dtindex, object field,
+                        object time_locale=None):


rename to locale

jreback · 2018-02-26T11:16:18Z

pandas/_libs/tslibs/fields.pyx

@@ -96,23 +97,37 @@ def get_date_name_field(ndarray[int64_t] dtindex, object field):
        pandas_datetimestruct dts
        int dow



instead of using _dayname, _monthname, use cdef names ndarray[object]

jreback · 2018-02-26T11:18:15Z

pandas/_libs/tslibs/nattype.pyx

+        month_name : string
+        """)
+    day_name = _make_nan_func('day_name', # noqa:E128
+        """


can you added versionadded 0.23 to these

jreback · 2018-02-26T11:20:25Z

pandas/tests/indexes/datetimes/test_misc.py

+                expected_months = calendar.month_name[1:]
+
+        # GH 11128
+        dti = DatetimeIndex(freq='D', start=datetime(1998, 1, 1),


can you add a NaT here

jreback · 2018-02-26T11:21:17Z

pandas/tests/indexes/datetimes/test_misc.py

+    @pytest.mark.skipif(not tm.get_locales(), reason='No available locales')
+    @pytest.mark.parametrize('time_locale', tm.get_locales() + [None])
+    def test_datetime_name_accessors(self, time_locale):
+        if time_locale is None:


add a comment what you are setting here

jreback · 2018-02-26T11:21:39Z

pandas/tests/indexes/datetimes/test_misc.py

+        for day, name, eng_name in zip(range(4, 11),
+                                       expected_days,
+                                       english_days):
+            # Test Monday -> Sunday


can you move this comment to near the GH issue number

jreback · 2018-02-26T11:21:46Z

pandas/tests/indexes/datetimes/test_misc.py

+
+        # GH 12805
+        dti = DatetimeIndex(freq='M', start='2012', end='2013')
+        # Test January -> December


same, move this up

add a NaT here

jreback · 2018-02-26T11:22:08Z

pandas/tests/scalar/timestamp/test_timestamp.py

        # GH 17354
-        assert data.weekday_name == expected
+        # Test .weekday_name, .day_name(), .month_name


test with NaT

mroeschke · 2018-02-27T02:27:17Z

I believe I addressed everything

Testing NaT
Moved/added comments to tests
Added tests for Series.dt.*name
Added versionadded notes
reused get_name_date_field in Timestamp
renamed time_locale to locale

jreback · 2018-02-27T02:30:08Z

pandas/_libs/tslibs/fields.pyx

    """
    Given a int64-based datetime index, return array of strings of date
    name based on requested field (e.g. weekday_name)
    """
    cdef:
        Py_ssize_t i, count = 0
-        ndarray[object] out
+        ndarray[object] out, name
        pandas_datetimestruct dts


should be names

jreback · 2018-02-27T02:31:33Z

pandas/_libs/tslibs/timestamps.pyx

+        """
+        warnings.warn("`weekday_name` is deprecated and will be removed in a "
+                      "future version. Use `day_name` instead",
+                      DeprecationWarning)


can u have this call day_name

mroeschke · 2018-03-01T06:51:03Z

Changed name to names, and used the day_name method for weekday_name. All green

jreback

very small comments, also needs a rebase. ping on green.

jreback · 2018-03-01T23:07:56Z

doc/source/api.rst

@@ -581,6 +581,8 @@ These can be accessed like ``Series.dt.<property>``.
   Series.dt.round
   Series.dt.floor
   Series.dt.ceil
+   Series.dt.month_name


if weekday_name is anywhere here can you remove

jreback · 2018-03-01T23:09:09Z

pandas/core/indexes/datetimes.py

@@ -262,6 +262,8 @@ class DatetimeIndex(DatelikeOps, TimelikeOps, DatetimeIndexOpsMixin,
    to_pydatetime
    to_series
    to_frame


if weekday_name is here can u remove

jreback · 2018-03-01T23:10:02Z

@jorisvandenbossche @TomAugspurger lgtm. if any final comments.

Fix localiztion of months Add series test and whatsnew notes Modify test and lint Add Timestamp rst Address comments Lint, move whatsnew, remove hardcoded Monday, check that get_locale is None create functions instead of attributes Fix white space Modify tests Lint Rebase and add depreciation message Deprecate weekday_name, create localizing function in ccalendar.pyx clean up imports Address user comments Try to address ci issues Rebase and adjust tests Move some imports to top of file, remove dup implimention of day_name in fields Fix failing test allow path to accept weekday_name as well address review address review missed files fix typo and call internal method Fix lint modify pytest param for appvoyer fix more appvoyer tests Remove weekday_name availability

mroeschke · 2018-03-02T16:12:38Z

Removed doc instances of weekday_name and all green (minus a Travis timeout)

jreback · 2018-03-04T20:15:43Z

thanks @mroeschke nice patch!

jreback · 2018-03-05T11:27:28Z

@mroeschke a number of deprecation warnings need catching.
also these should be FutureWarning and not DeprecationWarning. can you do a followup.

  /home/travis/build/pandas-dev/pandas/pandas/tests/indexes/datetimes/test_misc.py:274: DeprecationWarning: `weekday_name` is deprecated and will be removed in a future version. Use `day_name` instead
    assert ts.weekday_name == eng_name

@TomAugspurger

commit df2e361 Author: Jeff Reback <jeff@reback.net> Date: Sun Mar 11 18:33:25 2018 -0400 LINT: fixing commit f1c0b7c Author: David Polo <delkk0@users.noreply.github.com> Date: Sun Mar 11 22:54:27 2018 +0100 DOC: Improved the docstring of pandas.plotting._core.FramePlotMethods… (pandas-dev#20157) * DOC: Improved the docstring of pandas.plotting._core.FramePlotMethods.barh() - Added examples section - Added extended summary - Added argument explanation * DOC: Improved the docstring of pandas.plotting._core.FramePlotMethods.barh() - Correcting PR comments * DOC: Improved the docstring of pandas.plotting._core.FramePlotMethods.barh() - Adding defaults for variables. * Update reference commit 0780193 Author: Jonas Schulze <jonas.schulze7@t-online.de> Date: Sun Mar 11 22:37:37 2018 +0100 DOC: update the pandas.DataFrame.plot.density docstring (pandas-dev#20236) * DOC: update the pandas.DataFrame.plot.kde and pandas.Series.plot.kde docstrings Unfortunately, I was not able to compute a kernel estimate of a two-dimensional random variable. Hence, the example is more of an analysis of some independent data series. * DOC: extract similarities of kde docstrings The `DataFrame.plot.kde` and `Series.plot.kde` now use a common docstring, for which the differences are inserted. commit 2718984 Author: Cihan Ceyhan <chncyhn@gmail.com> Date: Sun Mar 11 21:48:08 2018 +0100 DOC: Update the pandas.Series.dt.round/floor/ceil docstrings (pandas-dev#20187) * DOC: Update the pandas.Series.dt.round/floor/ceil docstrings * DOC: review points fixed. * Add series commit 0d86742 Author: Antonio Molina <aydevosotros@gmail.com> Date: Sun Mar 11 18:57:37 2018 +0100 DOC: Improved pandas.plotting.bootstrap_plot docstring (pandas-dev#20166) * Improved documentation on bootstrap_plot * Improved documentation on bootstrap_plot * Doc bootstrap_plot: Fixed some comments on pull requests * Added reference to wikipedia * Changed kwds for **kwds * Removed ** from kwds becuase of validation iuses * Fixed forgotten break line. I think that the kwds paramater now fits what expected @TomAugspurger. If not, sorry and indicate how it should be * Fixed warnings on compilation * Moved reference to extended description commit a2910ad Author: András Novoszáth <nocibambi@gmail.com> Date: Sun Mar 11 18:56:01 2018 +0100 DOC: update the Index.get_values docstring (pandas-dev#20231) * DOC: update the Index.get_values docstring * Corrections * Corrected extended summary and quotes * Correcting spaces, extended summary, multiIndex example * See also correction * Multi ndim commit afa6c42 Author: Marc <mlafore05@gmail.com> Date: Sun Mar 11 10:42:35 2018 -0400 DOC: update the pandas.DataFrame.all docstring (pandas-dev#20216) commit a44bae3 Author: Victor Villas <villasv@outlook.com> Date: Sun Mar 11 11:41:12 2018 -0300 DOC: update the Series.view docstring (pandas-dev#20220) commit 233103f Author: David Adrián Cañones Castellano <davidarcano@gmail.com> Date: Sun Mar 11 15:40:02 2018 +0100 DOC: update the docstring of pandas.DataFrame.from_dict (pandas-dev#20259) commit 62bddec Author: csfarkas <csaba.farkas95@gmail.com> Date: Sun Mar 11 15:33:54 2018 +0100 DOC: add docstring for Index.get_duplicates (pandas-dev#20223) commit 8c77238 Author: adatasetaday <32177771+adatasetaday@users.noreply.github.com> Date: Sun Mar 11 10:17:05 2018 -0400 Docstring pandas.series.diff (pandas-dev#20238) commit 4271757 Author: Aly Sivji <4369343+alysivji@users.noreply.github.com> Date: Sun Mar 11 08:51:25 2018 -0500 DOC: update `pandas/core/ops.py` docstring template to accept examples (pandas-dev#20246) commit 080ef0c Author: akosel <aaronjkosel@gmail.com> Date: Sun Mar 11 12:43:10 2018 +0000 DOC: update the DataFrame.iat[] docstring (pandas-dev#20219) * DOC: update the DataFrame.iat[] docstring * Update based on PR comments * Update based on PR comments * Singular not plural * Update to account for use with Series. Add example using Series. * Update indexing.py * PEP8 commit 302fda4 Author: adatasetaday <32177771+adatasetaday@users.noreply.github.com> Date: Sun Mar 11 08:36:21 2018 -0400 DOC: update the pandas.DataFrame.diff docstring (pandas-dev#20227) * DOC: update the pandas.DataFrame.diff docstring * DOC: update the pandas.DataFrame.diff docstring * DOC: update the pandas.DataFrame.diff docstring * DOC: update the pandas.DataFrame.diff docstring * DOC: update the pandas.DataFrame.diff docstring * DOC: update the pandas.DataFrame.diff docstring * DOC: update the pandas.DataFrame.diff docstring * DOC: update the pandas.DataFrame.diff docstring * DOC: update the pandas.DataFrame.diff docstring * Cleanup commit c791a84 Author: Pietro Battiston <me@pietrobattiston.it> Date: Sun Mar 11 13:07:01 2018 +0100 DOC: pd.core.window.Expanding.kurt docstring (split from pd.core.Rolling.kurt) (pandas-dev#20064) commit b3d6ce6 Author: Nipun Sadvilkar <nipunsadvilkar@gmail.com> Date: Sun Mar 11 17:29:33 2018 +0530 DOC: update the pandas.date_range() docstring (pandas-dev#20143) * DOC: Improved the docstring of pandas.date_range() * Change date strings to iso format * Removed import pands in Examples docstring * Add See Also Docstring * Update datetimes.py * Doctests commit 6d7272a Author: Samuel Sinayoko <samuelsinayoko@bmlltech.com> Date: Sun Mar 11 11:58:09 2018 +0000 DOC: update DataFrame.to_records (pandas-dev#20191) * Update to_records docstring. - Minor changes (missing dots, newlines) to make tests pass. - More examples. * Fix html docs. Missing newlines. * Reword datetime type information. * flake8 errors * Fix typo (duplicated type) * Remove unwanted blank line after Examples. * Fix doctests. ``` (pandas_dev) sinayoks@landade:~/dev/pandas/ $ pytest --doctest-modules pandas/core/frame.py -k to_record ========================================================================================== test session starts ========================================================================================== platform darwin -- Python 3.6.4, pytest-3.4.2, py-1.5.2, pluggy-0.6.0 rootdir: /Users/sinayoks/dev/pandas, inifile: setup.cfg plugins: xdist-1.22.1, forked-0.2, cov-2.5.1 collected 43 items pandas/core/frame.py . [100%] ========================================================================================== 42 tests deselected ========================================================================================== ``` * Few more changes commit 636335a Author: Gabriel de Maeztu <gabriel.maeztu@gmail.com> Date: Sun Mar 11 12:56:48 2018 +0100 DOC: Improved the docstring of pandas.plotting.radviz (pandas-dev#20169) commit fbebc7f Author: jen w <j.e.weiss@gmail.com> Date: Sun Mar 11 06:50:54 2018 -0500 DOC: Update pandas.DataFrame.tail docstring (pandas-dev#20225) commit c2864d7 Author: Stephen Childs <sechilds@gmail.com> Date: Sun Mar 11 07:50:39 2018 -0400 DOC: update the DataFrame.cov docstring (pandas-dev#20245) * DOC: Revise docstring of DataFrame cov method Update the docstring with some examples from elsewhere in the pandas documentation. Some of the examples use randomly generated time series because we need to get covariance between long series. Used a random seed to ensure that the results are the same each time. * DOC: Fix See Also and min_periods explanation. Responding to comments on PR. See also section will link properly and number of periods explanation clearer. commit 90e31b9 Author: jen w <j.e.weiss@gmail.com> Date: Sun Mar 11 06:50:18 2018 -0500 DOC: update pandas.DataFrame.head docstring (pandas-dev#20262) commit fb556ed Author: Israel Saeta Pérez <dukebody@gmail.com> Date: Sat Mar 10 22:33:42 2018 +0100 DOC: Improve pandas.Series.plot.kde docstring and kwargs rewording for whole file (pandas-dev#20041) commit c3d491a Author: Andy R. Terrel <andy.terrel@gmail.com> Date: Sat Mar 10 11:48:13 2018 -0800 DOC: update the DataFrame.head() docstring (pandas-dev#20206) commit dd7f567 Author: DataOmbudsman <DataOmbudsman@users.noreply.github.com> Date: Sat Mar 10 20:15:48 2018 +0100 DOC: update the Index.shift docstring (pandas-dev#20192) * DOC: updating docstring of Index.shift * Add See Also section to shift * Update link to Series.shift commit 5b0caf4 Author: Eric O. LEBIGOT (EOL) <lebigot@users.noreply.github.com> Date: Sat Mar 10 17:32:20 2018 +0100 DOC: update the Series.memory_usage() docstring (pandas-dev#20086) commit 9fb7ac9 Author: Carol Willing <carolcode@willingconsulting.com> Date: Sat Mar 10 08:28:54 2018 -0800 DOC: Edit contributing to docs section (pandas-dev#20190) commit d8181a5 Author: DaanVanHauwermeiren <DaanVanHauwermeiren@users.noreply.github.com> Date: Sat Mar 10 17:25:20 2018 +0100 DOC: update the Series.isin docstring (pandas-dev#20175) commit ec631ce Author: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Date: Sat Mar 10 17:12:41 2018 +0100 DOC: update the pandas.Series.tail docstring (pandas-dev#20176) commit e5e4ae9 Author: DaanVanHauwermeiren <DaanVanHauwermeiren@users.noreply.github.com> Date: Sat Mar 10 16:41:58 2018 +0100 DOC: update the pandas.Index.drop_duplicates and pandas.Series.drop_duplicates docstring (pandas-dev#20114) commit d7bcb22 Author: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Date: Sat Mar 10 15:49:31 2018 +0100 DOC: update the MultiIndex.swaplevel docstring (pandas-dev#20105) commit 8497029 Author: Gjelt <math-and-data@users.noreply.github.com> Date: Sat Mar 10 15:41:17 2018 +0100 DOC: Improved the docstring of pandas.DataFrame.values (pandas-dev#20065) commit 840d432 Author: Jordi Contestí <25779507+jcontesti@users.noreply.github.com> Date: Sat Mar 10 13:24:35 2018 +0100 DOC: Improved the docstring of Series.str.findall (pandas-dev#19982) commit 2a0d23b Author: Jeff Reback <jeff@reback.net> Date: Sat Mar 10 06:54:19 2018 -0500 DOC: lint commit bf0dcb5 Author: Kate Surta <kate.surta@gmail.com> Date: Sat Mar 10 14:42:52 2018 +0300 BUG: Check for wrong arguments in index subclasses constructors (pandas-dev#20017) commit 4131149 Author: Stijn Van Hoey <stijnvanhoey@gmail.com> Date: Sat Mar 10 10:15:41 2018 +0100 DOC: Extend docstring pandas core index to_frame method (pandas-dev#20036) commit 52cffa3 Author: William Ayd <william.ayd@icloud.com> Date: Fri Mar 9 18:06:43 2018 -0800 Cythonized GroupBy pct_change (pandas-dev#19919) commit da6f827 Author: William Ayd <william.ayd@icloud.com> Date: Fri Mar 9 18:03:50 2018 -0800 Refactored GroupBy ASVs (pandas-dev#20043) commit bd31f71 Author: William Ayd <william.ayd@icloud.com> Date: Fri Mar 9 17:53:34 2018 -0800 Added 'displayed_only' option to 'read_html' (pandas-dev#20047) commit ed96567 Author: Ksenia <bobrovaksenia@gmail.com> Date: Sat Mar 10 02:40:10 2018 +0100 TST: series/indexing tests parametrization + moving test methods (pandas-dev#20059) commit 7c14e4f Author: Kyle Barron <kylebarron2@gmail.com> Date: Fri Mar 9 11:31:14 2018 -0500 DOC: Add syntax highlighting to SAS code blocks in comparison_with_sas.rst (pandas-dev#20080) * Add syntax highlighting to SAS code blocks * Fix typo commit 731d971 Author: Matthew Roeschke <emailformattr@gmail.com> Date: Fri Mar 9 03:30:22 2018 -0800 Fix typo in apply.py (pandas-dev#20058) commit cc1b934 Author: Matthew Roeschke <emailformattr@gmail.com> Date: Fri Mar 9 03:13:50 2018 -0800 BUG: Retain timezone dtype with cut and qcut (pandas-dev#19890) commit c730d08 Author: William Ayd <william.ayd@icloud.com> Date: Fri Mar 9 02:37:27 2018 -0800 DOC: Update Kurt Docstr (pandas-dev#20044) commit 9119d07 Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Fri Mar 9 10:03:44 2018 +0100 Temporary github PR template for sprint (pandas-dev#20055) commit 747501a Author: Aly Sivji <4369343+alysivji@users.noreply.github.com> Date: Fri Mar 9 02:19:59 2018 -0600 DOC: Improve docstring for pandas.Index.repeat (pandas-dev#19985) commit 1d73cf3 Author: Rouz Azari <rouzazari@users.noreply.github.com> Date: Thu Mar 8 16:54:53 2018 -0800 BUG: Dense ranking with percent now uses 100% basis (pandas-dev#15639) commit f9fd540 Author: William Ayd <william.ayd@icloud.com> Date: Thu Mar 8 16:36:23 2018 -0800 Added flake8 to DEV requirements (pandas-dev#20063) commit b669112 Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Thu Mar 8 14:09:12 2018 +0100 DOC: require returns section in validation script (pandas-dev#19994) commit 024d8b4 Author: Jeff Reback <jeff@reback.net> Date: Thu Mar 8 07:08:57 2018 -0500 TST: xfail test_time on py2 & mpl 1.4.3 (pandas-dev#20053) commit b85f6c1 Author: Marc Garcia <garcia.marc@gmail.com> Date: Thu Mar 8 11:07:08 2018 +0000 DOC: update docstring validation script + replace api coverage script (pandas-dev#20025) * Improvments to validate_docstrings script: adding sections to summary, validating type and description of parameters * DOC: Improvements to validate docstring script (added api_coverage functionality, sections in csv and extra validations) commit 9273bf5 Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Thu Mar 8 11:14:05 2018 +0100 DOC/CI: temp pin matplotlib for doc build (pandas-dev#20045) commit 63ce781 Author: Jeff Reback <jeff@reback.net> Date: Wed Mar 7 17:01:38 2018 -0500 TST: xfail mpl 2.2 tests xref pandas-dev#20031 commit 7c7bd56 Author: Daniel Frank <danfrankj@gmail.com> Date: Wed Mar 7 13:54:46 2018 -0800 enable multivalues insert (pandas-dev#19664) commit f33e84c Author: Ksenia <bobrovaksenia@gmail.com> Date: Wed Mar 7 22:09:42 2018 +0100 Moving tests in series/indexing to fixtures (pandas-dev#20014.1) (pandas-dev#20034) commit 2532a49 Author: Liam3851 <david.krych@gmail.com> Date: Wed Mar 7 13:04:22 2018 -0500 BUG: Fixes to msgpack support. (pandas-dev#19975) commit fd010de Author: Guilherme Beltramini <guilherme.beltramini@nubank.com.br> Date: Wed Mar 7 11:33:09 2018 -0300 to_sql also accepts Series (pandas-dev#20004) commit 8d462ed Author: Paul Reidy <paul_reidy@outlook.com> Date: Wed Mar 7 14:32:12 2018 +0000 EHN: Implement method argument for DataFrame.replace (pandas-dev#19894) commit d14fae8 Author: jbrockmendel <jbrockmendel@gmail.com> Date: Wed Mar 7 06:19:21 2018 -0800 cleanup ops (pandas-dev#19972) commit 776f2be Author: William Ayd <william.ayd@icloud.com> Date: Wed Mar 7 05:59:39 2018 -0800 Added .pytest_cache to gitignore (pandas-dev#20021) commit 460941f Author: jschendel <jschendel@users.noreply.github.com> Date: Wed Mar 7 06:57:51 2018 -0700 Fix typos in test_interval_new (pandas-dev#20026) commit 5782ab8 Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Wed Mar 7 14:57:17 2018 +0100 DOC: enable matplotlib plot_directive to include figures in docstrings (pandas-dev#20015) commit dd2b224 Author: DataOmbudsman <DataOmbudsman@users.noreply.github.com> Date: Wed Mar 7 14:56:49 2018 +0100 DOC: updating docstring of Index.shift (pandas-dev#19996) commit 09c416c Author: William Ayd <william.ayd@icloud.com> Date: Wed Mar 7 05:56:16 2018 -0800 DOC: Updated kurt docstring (for pandas sprint) (pandas-dev#19999) commit ad15f80 Author: Kate Surta <kate.surta@gmail.com> Date: Wed Mar 7 16:55:48 2018 +0300 TST: Fix wrong argument in TestDataFrameAlterAxes.test_set_index_dst (pandas-dev#20019) commit f6ee9ac Author: Jeff Reback <jeff@reback.net> Date: Wed Mar 7 08:55:33 2018 -0500 TST: xfail clip tests under numpy-dev (pandas-dev#20035) xref pandas-dev#19976 commit 397e296 Author: Jeff Reback <jeff@reback.net> Date: Wed Mar 7 08:15:49 2018 -0500 TST: xfail some tests for mpl 2.2 compat (pandas-dev#20033) xref pandas-dev#20031 commit 56939b4 Author: luzpaz <luzpaz@users.noreply.github.com> Date: Wed Mar 7 06:10:39 2018 -0500 DOC: misc typos (pandas-dev#20029) commit 01b91c2 Author: alinde1 <32714875+alinde1@users.noreply.github.com> Date: Tue Mar 6 22:47:45 2018 +0100 DOC: is confusing for ddof parameter of sem, var and std functions (pandas-dev#19986) commit db82165 Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Tue Mar 6 22:42:41 2018 +0100 CLN/DOC: cache_readonly: remove allow_setting + preserve docstring (pandas-dev#19991) commit e02f737 Author: Tom Augspurger <TomAugspurger@users.noreply.github.com> Date: Tue Mar 6 09:38:32 2018 -0600 DOC: add doc on ExtensionArray and extending pandas (pandas-dev#19936) commit 0ca77b3 Author: jbrockmendel <jbrockmendel@gmail.com> Date: Tue Mar 6 04:27:21 2018 -0800 Datetimelike add/sub catch cases more explicitly, tests (pandas-dev#19912) commit 0038bad Author: Matthew Roeschke <emailformattr@gmail.com> Date: Tue Mar 6 04:25:55 2018 -0800 month_name/day_name warnings followup (pandas-dev#20010) commit fd63c90 Author: Ksenia <bobrovaksenia@gmail.com> Date: Tue Mar 6 13:25:37 2018 +0100 TST: split series/test_indexing.py (pandas-dev#18614) (pandas-dev#20006) commit 6366bf0 Author: Jeff Reback <jeff@reback.net> Date: Tue Mar 6 07:25:17 2018 -0500 TST: clean deprecation warnings for xref pandas-dev#19980 (pandas-dev#20013) xfail some mpl > 2.1.2 tests commit fe61299 Author: William Ayd <william.ayd@icloud.com> Date: Tue Mar 6 00:30:13 2018 -0800 DOC: fixed dynamic import mechanics of make.py (pandas-dev#20005) commit 8a084eb Author: Grant Smith <grantsmith@gmail.com> Date: Tue Mar 6 03:29:26 2018 -0500 CLN: deprecate the pandas.tseries.plotting.tsplot function (GH18627) (pandas-dev#19980) commit aedbd94 Author: Jeff Reback <jeff@reback.net> Date: Mon Mar 5 06:36:41 2018 -0500 TST: text correction, xref pandas-dev#19987 commit cbffd19 Author: Bhavesh Poddar <bhavesh13103507@gmail.com> Date: Mon Mar 5 06:34:59 2018 -0500 fixed pytest deprecation warning (pandas-dev#19987) commit 058a16c Author: Matthew Roeschke <emailformattr@gmail.com> Date: Mon Mar 5 03:23:49 2018 -0800 CLN: Use generators in builtin functions (pandas-dev#19989) commit 607910b Author: Matthew Roeschke <emailformattr@gmail.com> Date: Sun Mar 4 12:15:37 2018 -0800 Add month names (pandas-dev#18164) commit 2fad756 Author: jbrockmendel <jbrockmendel@gmail.com> Date: Sun Mar 4 12:00:39 2018 -0800 transition period_helper to use pandas_datetimestruct (pandas-dev#19918) commit 53606ff Author: Liam3851 <david.krych@gmail.com> Date: Sun Mar 4 14:58:22 2018 -0500 BUG: Compat for pre-0.20 TimedeltaIndex and Float64Index pickles pandas-dev#19939 (pandas-dev#19943) commit 0bfb61b Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Fri Mar 2 22:35:45 2018 +0100 DOC: small updates to make.py script (pandas-dev#19951) * enable passing verbosity flag to sphinx * alias api for api.rst commit d1f3689 Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Fri Mar 2 22:33:48 2018 +0100 DOC: fix some sphinx syntax warnings (pandas-dev#19962) commit 49f09cc Author: Tom Augspurger <TomAugspurger@users.noreply.github.com> Date: Fri Mar 2 15:20:28 2018 -0600 API: Added ExtensionArray constructor from scalars (pandas-dev#19913) commit d30d165 Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Fri Mar 2 22:18:10 2018 +0100 DOC: update docstring validation script (pandas-dev#19960) commit a7a7f8c Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Fri Mar 2 13:49:59 2018 +0100 DOC: clarify version of ActivePython that includes pandas (pandas-dev#19964) commit b167483 Author: Gina <Dr-G@users.noreply.github.com> Date: Fri Mar 2 05:33:49 2018 -0600 DOC: update install.rst to include ActivePython distribution (pandas-dev#19908) commit e6c7dea Author: topper-123 <terji78@gmail.com> Date: Fri Mar 2 11:19:07 2018 +0000 ENH: Let initialisation from dicts use insertion order for python >= 3.6 (part III) (pandas-dev#19884) commit d615f86 Author: Marc Garcia <garcia.marc@gmail.com> Date: Fri Mar 2 09:39:45 2018 +0000 DOC: Adding script to validate docstrings, and generate list of all functions/methods with state (pandas-dev#19898) commit 5f271eb Author: Yian <yian.shang@gmail.com> Date: Fri Mar 2 00:13:58 2018 +0100 BUG: Adding skipna as an option to groupby cumsum and cumprod (pandas-dev#19914) commit 072545d Author: David C Hall <davidchall@users.noreply.github.com> Date: Thu Mar 1 15:06:20 2018 -0800 ENH: Add option to disable MathJax (pandas-dev#19824). (pandas-dev#19856) commit d44a6ec Author: Yian <yian.shang@gmail.com> Date: Fri Mar 2 00:02:31 2018 +0100 Making to_datetime('today') and Timestamp('today') consistent (pandas-dev#19937) commit 87fefe2 Author: jbrockmendel <jbrockmendel@gmail.com> Date: Thu Mar 1 14:54:42 2018 -0800 dispatch Series[datetime64] comparison ops to DatetimeIndex (pandas-dev#19800) commit 9242248 Author: Matthew Roeschke <emailformattr@gmail.com> Date: Thu Mar 1 14:50:35 2018 -0800 BUG: DataFrame.diff(axis=0) with DatetimeTZ data (pandas-dev#19773) commit c5a1ef1 Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Thu Mar 1 22:48:39 2018 +0100 DOC: remove empty attribute/method lists from class docstrings html page (pandas-dev#19949) commit 9958ce6 Author: jschendel <jschendel@users.noreply.github.com> Date: Thu Mar 1 04:14:19 2018 -0700 BUG: Preserve column metadata with DataFrame.astype (pandas-dev#19948) commit 3b4eb8d Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Thu Mar 1 12:12:35 2018 +0100 CLN: remove redundant clean_fill_method calls (pandas-dev#19947) commit c8859b5 Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Thu Mar 1 10:35:05 2018 +0100 DOC: script to build single docstring page (pandas-dev#19840) commit 52559f5 Author: Matthew Roeschke <emailformattr@gmail.com> Date: Wed Feb 28 17:32:24 2018 -0800 ENH: Allow Timestamp to accept Nanosecond argument (pandas-dev#19889) commit 4a27697 Author: William Ayd <william.ayd@icloud.com> Date: Wed Feb 28 17:30:18 2018 -0800 Cythonized GroupBy any (pandas-dev#19722) commit 96b8bb1 Author: jschendel <jschendel@users.noreply.github.com> Date: Wed Feb 28 18:07:15 2018 -0700 ENH: Implement DataFrame.astype('category') (pandas-dev#18099) commit 6ef4be3 Author: Liam3851 <david.krych@gmail.com> Date: Wed Feb 28 06:14:11 2018 -0500 ENH: Allow literal (non-regex) replacement using .str.replace pandas-dev#16808 (pandas-dev#19584) commit 318a287 Author: README Bot <35302948+codetriage-readme-bot@users.noreply.github.com> Date: Wed Feb 28 05:07:28 2018 -0600 Add CodeTriage badge to pandas-dev/pandas (pandas-dev#19928) Adds a badge showing the number of people helping this repo on CodeTriage. commit 14a38a6 Author: Chris Catalfo <ccatalfo@users.noreply.github.com> Date: Wed Feb 28 03:14:23 2018 -0500 DOC: fixes pipe example in basics.rst due to statsmodel changes (pandas-dev#19923) commit dfe9d4a Author: Phil Ngo <ngo.phil@gmail.com> Date: Wed Feb 28 00:05:56 2018 -0800 DOC: fix Series.reset_index example (pandas-dev#19930) commit 9bdc5c8 Author: William Ayd <william.ayd@icloud.com> Date: Tue Feb 27 16:16:48 2018 -0800 Consistent Timedelta Writing for all Excel Engines (pandas-dev#19921) commit 61211a8 Author: jbrockmendel <jbrockmendel@gmail.com> Date: Tue Feb 27 16:11:47 2018 -0800 Assorted _libs cleanups (pandas-dev#19887)

jreback requested changes Nov 8, 2017

View reviewed changes

jreback added Compat pandas objects compatability with Numpy or Python functions Enhancement Datetime Datetime data dtype labels Nov 8, 2017

mroeschke force-pushed the add_localtime branch from ca6eb78 to 52a1464 Compare November 9, 2017 07:24

jreback requested changes Nov 9, 2017

View reviewed changes

mroeschke force-pushed the add_localtime branch from 52a1464 to 6f39578 Compare November 10, 2017 03:32

jorisvandenbossche reviewed Nov 10, 2017

View reviewed changes

mroeschke force-pushed the add_localtime branch from 6f39578 to c4837dc Compare November 11, 2017 20:15

mroeschke force-pushed the add_localtime branch from c4837dc to 18822e6 Compare November 20, 2017 19:43

mroeschke force-pushed the add_localtime branch from 18822e6 to 1162f9a Compare November 22, 2017 01:43

mroeschke mentioned this pull request Dec 12, 2017

centralize and de-privatize month/day name constants #18728

Merged

4 tasks

mroeschke force-pushed the add_localtime branch from 1162f9a to ab57006 Compare January 12, 2018 05:48

jreback requested changes Jan 12, 2018

View reviewed changes

mroeschke force-pushed the add_localtime branch from ab57006 to b0aeb3e Compare January 13, 2018 06:25

jreback requested changes Jan 13, 2018

View reviewed changes

mroeschke force-pushed the add_localtime branch from 62181e6 to 025ab67 Compare January 14, 2018 05:18

mroeschke force-pushed the add_localtime branch 2 times, most recently from 616665a to 565b5b6 Compare February 26, 2018 01:58

jsexauer mentioned this pull request Feb 26, 2018

DEPR: Clean up list of deprecations from prior versions #6581

Closed

1 task

jreback requested changes Feb 26, 2018

View reviewed changes

mroeschke force-pushed the add_localtime branch from 72f5b01 to a1cd27b Compare February 27, 2018 02:23

jreback requested changes Feb 27, 2018

View reviewed changes

mroeschke force-pushed the add_localtime branch 2 times, most recently from 006ac9e to dbbfbe7 Compare February 28, 2018 19:04

jreback added this to the 0.23.0 milestone Mar 1, 2018

jreback approved these changes Mar 1, 2018

View reviewed changes

mroeschke force-pushed the add_localtime branch from 56d1f01 to d97f43b Compare March 2, 2018 03:27

TomAugspurger approved these changes Mar 2, 2018

View reviewed changes

jreback merged commit 607910b into pandas-dev:master Mar 4, 2018

mroeschke deleted the add_localtime branch March 5, 2018 05:44

mroeschke mentioned this pull request Mar 6, 2018

month_name/day_name warnings followup #20010

Merged

1 task

jreback mentioned this pull request Mar 6, 2018

CLN: followons to refactor of series/test_indexing.py #20014

Closed

3 tasks

jbrockmendel mentioned this pull request Apr 29, 2018

PERF: Regressions since v0.21 #18532

Closed

mroeschke mentioned this pull request Nov 25, 2019

DEPR: Remove weekday_name #29831

Merged

5 tasks

jreback mentioned this pull request Nov 28, 2019

DEPR: deprecations log for removed issues #13777

Closed

nameloCmaS mentioned this pull request Jan 15, 2024

dt.weekday_name - attribute removed from Pandas v1.0.0 pydata/xarray#8610

Closed

5 tasks

		@@ -42,8 +42,13 @@ _nat_scalar_rules[Py_GE] = False
		def _make_nan_func(func_name, cls):

		@@ -96,23 +97,37 @@ def get_date_name_field(ndarray[int64_t] dtindex, object field):
		pandas_datetimestruct dts
		int dow

ENH: Return locale based month_name and weekday_name values (#12805, #12806) #18164

ENH: Return locale based month_name and weekday_name values (#12805, #12806) #18164

Conversation

mroeschke commented Nov 8, 2017 • edited by jreback Loading

jreback commented Nov 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mroeschke commented Nov 9, 2017

Choose a reason for hiding this comment

codecov bot commented Nov 10, 2017

Codecov Report

codecov bot commented Nov 10, 2017 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jorisvandenbossche commented Nov 10, 2017

jorisvandenbossche commented Nov 10, 2017

jorisvandenbossche commented Nov 10, 2017

mroeschke commented Nov 10, 2017

jreback commented Nov 10, 2017

mroeschke commented Nov 20, 2017

jreback commented Nov 23, 2017

mroeschke commented Jan 12, 2018

jreback left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mroeschke commented Jan 13, 2018 • edited Loading

jreback left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented Feb 25, 2018

mroeschke commented Feb 26, 2018

jreback left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mroeschke commented Feb 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mroeschke commented Mar 1, 2018

jreback left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented Mar 1, 2018

mroeschke commented Mar 2, 2018

jreback commented Mar 4, 2018

jreback commented Mar 5, 2018

mroeschke commented Nov 8, 2017 •

edited by jreback

Loading

codecov bot commented Nov 10, 2017 •

edited

Loading

mroeschke commented Jan 13, 2018 •

edited

Loading