Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Disallow dtypes w/o frequency when casting #23392

Merged
merged 1 commit into from
Oct 28, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Oct 28, 2018

Previously deprecated for Series constructor and the .astype method. Now being enforced.

xref #15987.

@gfyoung gfyoung added Datetime Datetime data dtype Dtype Conversions Unexpected or buggy dtype conversions API Design Deprecate Functionality to remove in pandas labels Oct 28, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Oct 28, 2018
@pep8speaks
Copy link

Hello @gfyoung! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Oct 28, 2018

Codecov Report

Merging #23392 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23392      +/-   ##
==========================================
- Coverage   92.16%   92.16%   -0.01%     
==========================================
  Files         166      166              
  Lines       51224    51222       -2     
==========================================
- Hits        47212    47208       -4     
- Misses       4012     4014       +2
Flag Coverage Δ
#multiple 90.59% <100%> (-0.01%) ⬇️
#single 42.22% <20%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/dtypes/cast.py 88.92% <100%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62a15fa...4c0d882. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Oct 28, 2018

@jbrockmendel can you have a look see.

@jreback
Copy link
Contributor

jreback commented Oct 28, 2018

I remember this now, so this lgtm.

Previously deprecated for Series constructor
and the `.astype` method. Now being enforced.

xref pandas-devgh-15987.
@gfyoung
Copy link
Member Author

gfyoung commented Oct 28, 2018

@jreback : Rebased, and all is green. PTAL.

@jreback jreback merged commit 10668d2 into pandas-dev:master Oct 28, 2018
@jreback
Copy link
Contributor

jreback commented Oct 28, 2018

thanks @gfyoung

@jbrockmendel
Copy link
Member

Small comments aside, LGTM.

@jreback
Copy link
Contributor

jreback commented Oct 28, 2018

@gfyoung if you can follow up with those comments in another PR

@gfyoung gfyoung deleted the dtype-timestamp-no-freq branch October 28, 2018 18:52
gfyoung added a commit to forking-repos/pandas that referenced this pull request Oct 28, 2018
* Use 'unit' instead of 'frequency'
* Minor spacing issues in docs
gfyoung added a commit that referenced this pull request Oct 28, 2018
* Use 'unit' instead of 'frequency'
* Minor spacing issues in docs

Follow-up to gh-23392
thoo added a commit to thoo/pandas that referenced this pull request Oct 30, 2018
…y_tests

* repo_org/master: (52 commits)
  ENH: Allow rename_axis to specify index and columns arguments  (pandas-dev#20046)
  STY: proposed isort settings [ci skip] [skip ci] [ciskip] [skipci] (pandas-dev#23366)
  MAINT: Remove extraneous test.parquet file
  CLN: Follow-up comments to pandas-devgh-23392 (pandas-dev#23401)
  BUG GH23282 calling min on series of NaT returns NaT (pandas-dev#23289)
  unpin openpyxl (pandas-dev#23361)
  REF: collect ops dispatch functions in one place, try to de-duplicate SparseDataFrame methods (pandas-dev#23060)
  CLN: Remove pandas.tools module (pandas-dev#23376)
  CLN: Remove some dtype methods from API (pandas-dev#23390)
  CLN: Cleanup toplevel namespace shims (pandas-dev#23386)
  DOC: fixup whatsnew note for GH21394 (pandas-dev#23355)
  Fix import format at pandas/tests/extension directory (pandas-dev#23365)
  DOC: Remove Series.sortlevel from api.rst (pandas-dev#23395)
  API: Disallow dtypes w/o frequency when casting (pandas-dev#23392)
  BUG/TST/REF: Datetimelike Arithmetic Methods (pandas-dev#23215)
  STYLE: lint
  add np.nan* funcs to cython_table (pandas-dev#22109)
  Run Isort on tests/util single PR (pandas-dev#23347)
  BUG: Fix date_range overflow (pandas-dev#23345)
  Run Isort on tests/arrays single PR (pandas-dev#23346)
  ...
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Previously deprecated for Series constructor
and the `.astype` method. Now being enforced.

xref pandas-devgh-15987.
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
* Use 'unit' instead of 'frequency'
* Minor spacing issues in docs

Follow-up to pandas-devgh-23392
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Previously deprecated for Series constructor
and the `.astype` method. Now being enforced.

xref pandas-devgh-15987.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
* Use 'unit' instead of 'frequency'
* Minor spacing issues in docs

Follow-up to pandas-devgh-23392
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Previously deprecated for Series constructor
and the `.astype` method. Now being enforced.

xref pandas-devgh-15987.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
* Use 'unit' instead of 'frequency'
* Minor spacing issues in docs

Follow-up to pandas-devgh-23392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design Datetime Datetime data dtype Deprecate Functionality to remove in pandas Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants