Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Remove PY2/3 references io directory #25886

Merged
merged 1 commit into from
Mar 28, 2019
Merged

CLN: Remove PY2/3 references io directory #25886

merged 1 commit into from
Mar 28, 2019

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Mar 26, 2019

xref #25725

@gfyoung gfyoung added this to the 0.25.0 milestone Mar 26, 2019
@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #25886 into master will increase coverage by 0.13%.
The diff coverage is 94.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25886      +/-   ##
==========================================
+ Coverage   91.48%   91.62%   +0.13%     
==========================================
  Files         175      175              
  Lines       52885    52777     -108     
==========================================
- Hits        48380    48355      -25     
+ Misses       4505     4422      -83
Flag Coverage Δ
#multiple 90.18% <94.87%> (+0.13%) ⬆️
#single 41.88% <58.97%> (+0.05%) ⬆️
Impacted Files Coverage Δ
pandas/io/excel/_base.py 92.89% <ø> (+0.4%) ⬆️
pandas/io/pytables.py 90.23% <100%> (+0.03%) ⬆️
pandas/io/formats/format.py 97.99% <100%> (ø) ⬆️
pandas/io/formats/printing.py 85.63% <100%> (+0.29%) ⬆️
pandas/io/common.py 91.91% <100%> (+19.05%) ⬆️
pandas/io/sas/sas_xport.py 90.09% <100%> (-0.05%) ⬇️
pandas/io/s3.py 89.47% <100%> (+3.11%) ⬆️
pandas/io/formats/terminal.py 34.78% <100%> (+2.25%) ⬆️
pandas/io/packers.py 88.08% <100%> (-0.04%) ⬇️
pandas/io/clipboards.py 100% <100%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d404460...8f7b01e. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 26, 2019 •
edited
Loading

Codecov Report

Merging #25886 into master will increase coverage by 0.2%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #25886     +/-   ##
=========================================
+ Coverage   91.56%   91.77%   +0.2%     
=========================================
  Files         175      175             
  Lines       52775    52607    -168     
=========================================
- Hits        48324    48278     -46     
+ Misses       4451     4329    -122
Flag Coverage Δ
#multiple 90.32% <93.18%> (+0.2%) ⬆️
#single 41.9% <65.9%> (+0.01%) ⬆️
Impacted Files Coverage Δ
pandas/io/excel/_base.py 92.89% <ø> (+0.4%) ⬆️
pandas/io/formats/console.py 78.12% <100%> (ø) ⬆️
pandas/io/common.py 91.87% <100%> (+19%) ⬆️
pandas/io/excel/_xlrd.py 94.02% <100%> (+0.09%) ⬆️
pandas/io/formats/terminal.py 66.66% <100%> (+34.95%) ⬆️
pandas/io/packers.py 88.08% <100%> (-0.04%) ⬇️
pandas/io/formats/csvs.py 98.2% <100%> (-0.02%) ⬇️
pandas/core/arrays/categorical.py 95.96% <100%> (ø) ⬆️
pandas/io/excel/_util.py 87.67% <100%> (+8.84%) ⬆️
pandas/io/s3.py 89.47% <100%> (+3.11%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31b4019...ad97232. Read the comment docs.

jreback
jreback requested changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. some comments

pandas/io/common.py Outdated Show resolved Hide resolved
pandas/io/common.py Outdated Show resolved Hide resolved
pandas/io/common.py Show resolved Hide resolved
pandas/io/formats/terminal.py Show resolved Hide resolved
@gfyoung gfyoung force-pushed the io-parsers-py2-drop branch 2 times, most recently from 9f5ee76 to 82721f6 Compare March 26, 2019 23:53
@gfyoung gfyoung force-pushed the io-parsers-py2-drop branch 2 times, most recently from b7318fb to 8f7b01e Compare March 27, 2019 03:40
@gfyoung
Copy link
Member Author

gfyoung commented Mar 27, 2019

@jreback : I left the UnicodeReader / UnicodeWriter classes alone for the reasons I described above. PTAL.

jreback
jreback requested changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. couple of comments

pandas/io/clipboards.py Show resolved Hide resolved
pandas/io/common.py Show resolved Hide resolved
pandas/io/formats/terminal.py Show resolved Hide resolved
@gfyoung gfyoung force-pushed the io-parsers-py2-drop branch 2 times, most recently from 51a09cf to 7d3be20 Compare March 27, 2019 22:03
@gfyoung
Copy link
Member Author

gfyoung commented Mar 27, 2019

@jreback : Addressed all comments, and everything is green. PTAL.

@gfyoung gfyoung force-pushed the io-parsers-py2-drop branch 2 times, most recently from 0202078 to d99fa99 Compare March 28, 2019 01:35
jreback
jreback requested changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. if you can update the comment indicated above (e.g. has refernces to old version)

pandas/io/clipboards.py Show resolved Hide resolved
@jreback jreback merged commit 96a128e into pandas-dev:master Mar 28, 2019
@jreback
Copy link
Contributor

jreback commented Mar 28, 2019

thanks @gfyoung very nice!

@gfyoung gfyoung deleted the io-parsers-py2-drop branch March 29, 2019 00:51
@gfyoung gfyoung mentioned this pull request Mar 29, 2019
Merged
gfyoung added a commit to forking-repos/pandas that referenced this pull request Mar 29, 2019
@gfyoung
CLN: Remove io/formats/terminal.py
4f3d078 
Remaining is_terminal function is
used in core/config_init.py, and
as this function is not meant to
be public, we can move it there.

This will help with dependency
organization of pandas' modules.

Follow-up to pandas-devgh-25886.
jreback pushed a commit that referenced this pull request Mar 29, 2019
@gfyoung @jreback
CLN: Remove io/formats/terminal.py (#25916)
d2d9e2d 
Remaining is_terminal function is
used in core/config_init.py, and
as this function is not meant to
be public, we can move it there.

This will help with dependency
organization of pandas' modules.

Follow-up to gh-25886.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@jschendel jschendel jschendel left review comments

@WillAyd WillAyd WillAyd left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
5 participants
@gfyoung @jreback @WillAyd @jschendel @jbrockmendel