CLN: Remove io/formats/terminal.py #25916
Conversation
Remaining is_terminal function is used in core/config_init.py, and as this function is not meant to be public, we can move it there. This will help with dependency organization of pandas' modules. Follow-up to pandas-devgh-25886.
gfyoung
added
IO Data
gfyoung
force-pushed
the
io-fmt-term-remove
branch
from
79755b1
to
4f3d078
Compare
Codecov Report
@@ Coverage Diff @@
## master #25916 +/- ##
==========================================
- Coverage 91.77% 91.76% -0.01%
==========================================
Files 175 174 -1
Lines 52606 52604 -2
==========================================
- Hits 48280 48274 -6
- Misses 4326 4330 +4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #25916 +/- ##
==========================================
- Coverage 91.77% 91.76% -0.01%
==========================================
Files 175 174 -1
Lines 52606 52604 -2
==========================================
- Hits 48280 48274 -6
- Misses 4326 4330 +4
Continue to review full report at Codecov.
|
| Returns True if Python is running in a terminal or False if not. | ||
| """ | ||
| try: | ||
| ip = get_ipython() |
There was a problem hiding this comment.
I would expect flake8 to complain about this (F821 I think). Any idea why it doesn’t?
Low priority: could make the docstring follow the standard format
There was a problem hiding this comment.
I would expect flake8 to complain about this (F821 I think)
Uncertain. I don't think it's because of the try-except block wrapping it?
Low priority: could make the docstring follow the standard format
Agreed on priority. Can always do after.
|
thanks @gfyoung |
Remaining is_terminal function is used in
core/config_init.py, and as this function is not meant to be public, we can move it there.This will help with dependency organization of pandas' modules.
Follow-up to #25886.
cc @jbrockmendel