Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation linking to sqlalchemy #29363

Closed
wants to merge 1 commit into from

Conversation

cruzzoe
Copy link
Contributor

@cruzzoe cruzzoe commented Nov 2, 2019

@alimcmaster1
Copy link
Member

Thanks very much for the PR:

You can do something like:

For documentation on pyarrow, see `here
        <https://arrow.apache.org/docs/python/index.html>`__.

For reference see:
https://sublime-and-sphinx-guide.readthedocs.io/en/latest/references.html

To avoid it rendering like so:

image

@alimcmaster1 alimcmaster1 self-requested a review November 2, 2019 18:18
@@ -2646,6 +2646,10 @@ def to_sql(
con : sqlalchemy.engine.Engine or sqlite3.Connection
Using SQLAlchemy makes it possible to use any DB supported by that
library. Legacy support is provided for sqlite3.Connection objects.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments in the PR - thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback - new pull request here: f080f98

@cruzzoe cruzzoe force-pushed the 23086 branch 2 times, most recently from 5c32f95 to 343ae40 Compare November 2, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It is not clear whether database connection need to be closed manually after calling pd.read_sql()
3 participants