Add documentation linking to sqlalchemy #29373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey - Can you submit updates on the same PR #29363 in the future - means we don’t have to re-review.. |
|
Sure. Sorry, didn't know what the correct process was.
…On Sat, 2 Nov 2019, 23:56 alimcmaster1, ***@***.***> wrote:
Hey - Can you submit updates on the same PR #29363
<#29363> in the future - means
we don’t have to re-review..
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#29373?email_source=notifications&email_token=ACXR24RLKYL6A6KCSZSNGPLQRYHRXA5CNFSM4JIHRNZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC5HSCY#issuecomment-549091595>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACXR24S5DMZ4UE3DZFZDXE3QRYHRXANCNFSM4JIHRNZQ>
.
|
WillAyd
reviewed
Nov 4, 2019
|
Yes. Without the continuation it would not render correctly
…On Mon, 4 Nov 2019, 16:16 William Ayd, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pandas/core/generic.py
<#29373 (comment)>:
> @@ -2646,6 +2646,10 @@ def to_sql(
con : sqlalchemy.engine.Engine or sqlite3.Connection
Using SQLAlchemy makes it possible to use any DB supported by that
library. Legacy support is provided for sqlite3.Connection objects.
+
+ Closing the connection is handled by the SQLAlchemy Engine. See `here \
Is this continuation necessary? Don't think we have anywhere else?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#29373?email_source=notifications&email_token=ACXR24TV7YBIBMVJDKXW7EDQSBDEDA5CNFSM4JIHRNZ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKGET5A#pullrequestreview-311183860>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACXR24UPCPMYWUERVRTBILTQSBDEDANCNFSM4JIHRNZQ>
.
|
WillAyd
requested changes
Nov 4, 2019
There was a problem hiding this comment.
Might be a personal thing but I find the wording here rather confusing. By saying Closing the connection is handled by the SQLAlchemy Engine I got the impression it was done automatically, but that is not the case. Any chance you can clarify or reword that to make it clear that pandas does nothing special here, i.e. the user is responsible for management of the connection?
There was a previous PR #27972 that was pretty close to getting merged if you'd like to take a look
|
I'm thinking we do something like this - similar to the other PR:
@WillAyd do you agree? I also got confused by current wording. |
|
Yea that sounds like a great idea |
|
LGTM (But I’m on mobile so can’t do a doc build to check how this renders). |
alimcmaster1
reviewed
Nov 7, 2019
| library. Legacy support is provided for sqlite3.Connection objects. The user | ||
| is responsible for engine disposal and connection closure for the SQLAlchemy | ||
| connectable See `here \ | ||
| <https://docs.sqlalchemy.org/en/13/core/connections.html>`_ |
There was a problem hiding this comment.
Not sure if the blank line is necessary
|
Content looks good. Can you build locally and just post a screenshot of how it renders to be safe? |
|
WillAyd
approved these changes
Nov 22, 2019
|
Thanks @cruzzoe ! |
keechongtan
added a commit
to keechongtan/pandas
that referenced
this pull request
Nov 25, 2019
…ndexing-1row-df * upstream/master: (185 commits) ENH: add BooleanArray extension array (pandas-dev#29555) DOC: Add link to dev calendar and meeting notes (pandas-dev#29737) ENH: Add built-in function for Styler to format the text displayed for missing values (pandas-dev#29118) DEPR: remove statsmodels/seaborn compat shims (pandas-dev#29822) DEPR: remove Index.summary (pandas-dev#29807) DEPR: passing an int to read_excel use_cols (pandas-dev#29795) STY: fstrings in io.pytables (pandas-dev#29758) BUG: Fix melt with mixed int/str columns (pandas-dev#29792) TST: add test for ffill/bfill for non unique multilevel (pandas-dev#29763) Changed description of parse_dates in read_excel(). (pandas-dev#29796) BUG: pivot_table not returning correct type when margin=True and aggfunc='mean' (pandas-dev#28248) REF: Create _lib/window directory (pandas-dev#29817) Fixed small mistake (pandas-dev#29815) minor cleanups (pandas-dev#29798) DEPR: enforce deprecations in core.internals (pandas-dev#29723) add test for unused level raises KeyError (pandas-dev#29760) Add documentation linking to sqlalchemy (pandas-dev#29373) io/parsers: ensure decimal is str on PythonParser (pandas-dev#29743) Reenabled no-unused-function (pandas-dev#29767) CLN:F-string in pandas/_libs/tslibs/*.pyx (pandas-dev#29775) ... # Conflicts: # pandas/tests/frame/indexing/test_indexing.py
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff