Fix mypy errors for pandas\tests\series\test_operators.py #29826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaturnFromTitan
force-pushed
the
mypy-pandas-tests-series-test_operators
branch
2 times, most recently
from
44806e1
to
5922a8c
Compare
they are added in add_flex_arithmetic_methods which is passed the class as a parameter. They could therefore be specific to a class and so adding them directly in Series (and adding similar in DataFrame separately) seems reasonable to me. |
simonjayhawkins
added
Testing
SaturnFromTitan
force-pushed
the
mypy-pandas-tests-series-test_operators
branch
from
5d144f5
to
8fe766e
Compare
38 tasks
simonjayhawkins
approved these changes
Nov 26, 2019
SaturnFromTitan
force-pushed
the
mypy-pandas-tests-series-test_operators
branch
from
8fe766e
to
8392174
Compare
SaturnFromTitan
force-pushed
the
mypy-pandas-tests-series-test_operators
branch
from
8392174
to
b2ee5ed
Compare
|
@simonjayhawkins the build is green again |
|
Thanks @SaturnFromTitan |
keechongtan
added a commit
to keechongtan/pandas
that referenced
this pull request
Nov 29, 2019
…ndexing-1row-df * upstream/master: (32 commits) DEPR: Series.cat.categorical (pandas-dev#29914) DEPR: infer_dtype default for skipna is now True (pandas-dev#29876) Fix broken asv (pandas-dev#29906) DEPR: Remove weekday_name (pandas-dev#29831) Fix mypy errors for pandas\tests\series\test_operators.py (pandas-dev#29826) CI: Setting path only once in GitHub Actions (pandas-dev#29867) DEPR: passing td64 data to DTA or dt64 data to TDA (pandas-dev#29794) CLN: remove unsupported sparse code from io.pytables (pandas-dev#29863) x.__class__ TO type(x) (pandas-dev#29889) DEPR: ftype, ftypes (pandas-dev#29895) REF: use named funcs instead of lambdas (pandas-dev#29841) Correct type inference for UInt64Index during access (pandas-dev#29420) CLN: follow-up to 29725 (pandas-dev#29890) CLN: trim unnecessary code in indexing tests (pandas-dev#29845) TST added test for groupby agg on mulitlevel column (pandas-dev#29772) (pandas-dev#29866) mypy fix (pandas-dev#29891) Typing annotations (pandas-dev#29850) Fix mypy error in pandas/tests.indexes.test_base.py (pandas-dev#29188) CLN: remove never-used kwargs, make kwargs explicit (pandas-dev#29873) TYP: Added typing to __eq__ functions (pandas-dev#29818) ...
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #28926
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThe errors were:
The problem is that these methods are only added at RunTime, so mypy can't see them. I'm not sure if my solution is the best way to silence these errors though.