Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYP: Typing annotations in clipboard #29850

Merged
merged 3 commits into from
Nov 27, 2019

Conversation

ShaharNaveh
Copy link
Member

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@ShaharNaveh ShaharNaveh changed the title CLN: Typing annotations in clipboard TYP: Typing annotations in clipboard Nov 26, 2019
@WillAyd
Copy link
Member

WillAyd commented Nov 27, 2019

Hmm +/-0 on this one. Actually might be nice to do the annotations upstream in pyperclip and vendor down as appropriate rather than us trying to do here

@jreback
Copy link
Contributor

jreback commented Nov 27, 2019

agree with @WillAyd that should vendor these, but ok to do both; pls rebase

@jreback jreback added the Typing type annotations, mypy/pyright type checking label Nov 27, 2019
@WillAyd WillAyd added this to the 1.0 milestone Nov 27, 2019
@WillAyd WillAyd merged commit d36bc70 into pandas-dev:master Nov 27, 2019
@WillAyd
Copy link
Member

WillAyd commented Nov 27, 2019

Thanks @MomIsBestFriend really appreciate the PRs. As mentioned if you could do this upstream in Pyperclip would be great as well

@ShaharNaveh ShaharNaveh deleted the TYP-io-clipboard branch November 27, 2019 18:12
keechongtan added a commit to keechongtan/pandas that referenced this pull request Nov 29, 2019
…ndexing-1row-df

* upstream/master: (32 commits)
  DEPR: Series.cat.categorical (pandas-dev#29914)
  DEPR: infer_dtype default for skipna is now True (pandas-dev#29876)
  Fix broken asv (pandas-dev#29906)
  DEPR: Remove weekday_name (pandas-dev#29831)
  Fix mypy errors for pandas\tests\series\test_operators.py (pandas-dev#29826)
  CI: Setting path only once in GitHub Actions (pandas-dev#29867)
  DEPR: passing td64 data to DTA or dt64 data to TDA (pandas-dev#29794)
  CLN: remove unsupported sparse code from io.pytables (pandas-dev#29863)
  x.__class__ TO type(x) (pandas-dev#29889)
  DEPR: ftype, ftypes (pandas-dev#29895)
  REF: use named funcs instead of lambdas (pandas-dev#29841)
  Correct type inference for UInt64Index during access (pandas-dev#29420)
  CLN: follow-up to 29725 (pandas-dev#29890)
  CLN: trim unnecessary code in indexing tests (pandas-dev#29845)
  TST added test for groupby agg on mulitlevel column (pandas-dev#29772) (pandas-dev#29866)
  mypy fix (pandas-dev#29891)
  Typing annotations (pandas-dev#29850)
  Fix mypy error in pandas/tests.indexes.test_base.py (pandas-dev#29188)
  CLN: remove never-used kwargs, make kwargs explicit (pandas-dev#29873)
  TYP: Added typing to __eq__ functions (pandas-dev#29818)
  ...
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants