Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix Categorical.min / max bug #33513

Merged
merged 1 commit into from
Apr 13, 2020
Merged

BUG: Fix Categorical.min / max bug #33513

merged 1 commit into from
Apr 13, 2020

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented Apr 13, 2020

jorisvandenbossche
jorisvandenbossche approved these changes Apr 13, 2020
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jorisvandenbossche jorisvandenbossche added Categorical Categorical Data Type Regression Functionality that used to work in a prior pandas version labels Apr 13, 2020
@jorisvandenbossche jorisvandenbossche added this to the 1.1 milestone Apr 13, 2020
@jorisvandenbossche jorisvandenbossche merged commit 70ca246 into pandas-dev:master Apr 13, 2020
@jreback
Copy link
Contributor

jreback commented Apr 13, 2020

pls do a PR where you test on Series as well

@jreback
Copy link
Contributor

jreback commented Apr 13, 2020

joris pls don’t merge so fast

@dsaxton dsaxton deleted the cat-max-with-only-nan branch April 13, 2020 14:19
@dsaxton dsaxton mentioned this pull request Apr 13, 2020
Merged
@jorisvandenbossche jorisvandenbossche modified the milestones: 1.1, 1.0.4 May 5, 2020
simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this pull request May 6, 2020
@dsaxton @simonjayhawkins
Backport PR pandas-dev#33513 on branch 1.0.x (BUG: Fix Categorical.mi…
9f1269f 
…n / max bug)
@simonjayhawkins simonjayhawkins mentioned this pull request May 6, 2020
Merged
simonjayhawkins added a commit that referenced this pull request May 6, 2020
@simonjayhawkins @dsaxton
Backport PR #33513 on branch 1.0.x (BUG: Fix Categorical.min / max bu…
2544c3a 
…g) (#34022)

Co-authored-by: Daniel Saxton <2658661+dsaxton@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Categorical Categorical Data Type Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.0.4
Development

Successfully merging this pull request may close these issues.

BUG: maximum of pd.Series([np.nan],dtype=ordered_category) raise
3 participants
@dsaxton @jreback @jorisvandenbossche