TST: Add Categorical Series test #33525
Conversation
| @@ -90,10 +90,13 @@ def test_min_max_with_nan(self, skipna): | |||
|
|
|||
| @pytest.mark.parametrize("function", ["min", "max"]) | |||
| @pytest.mark.parametrize("skipna", [True, False]) | |||
| def test_min_max_only_nan(self, function, skipna): | |||
| @pytest.mark.parametrize("box_in_series", [True, False]) | |||
There was a problem hiding this comment.
CategoricalIndex, DataFrame col?
There was a problem hiding this comment.
There are Series tests elsewhere for Categorical min/max, eg the previous PR that touched the Categorical.min/max implementation added the Series tests in reductions/test_reductions.py: 37526c1, so I would update the tests there instead of here in this file
There was a problem hiding this comment.
@jorisvandenbossche Do you mean do that instead of what I'm doing here, or rather that CategoricalIndex and DataFrame cases should be added to test_reductions.py instead of here?
There was a problem hiding this comment.
yes the point is to do these in test_reductions.py, adding a similiar missing categorical test there
alimcmaster1
added
the
Testing
| @@ -90,10 +90,13 @@ def test_min_max_with_nan(self, skipna): | |||
|
|
|||
| @pytest.mark.parametrize("function", ["min", "max"]) | |||
| @pytest.mark.parametrize("skipna", [True, False]) | |||
| def test_min_max_only_nan(self, function, skipna): | |||
| @pytest.mark.parametrize("box_in_series", [True, False]) | |||
There was a problem hiding this comment.
yes the point is to do these in test_reductions.py, adding a similiar missing categorical test there
|
thanks @dsaxton |
Follow up to #33513
cc @jreback