-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: fix construction from read-only non-ns datetime64 numpy array #34844
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,19 @@ | |
from pandas.core.base import NoNewAttributesMixin, PandasObject | ||
|
||
|
||
@pytest.fixture( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jorisvandenbossche if you hadn’t merged this so quickly i would have objected here creating this fixture for a single use is not that great we typically also call this klass and don’t much care about dataframe-dict here |
||
params=[ | ||
Series, | ||
lambda x, **kwargs: DataFrame({"a": x}, **kwargs)["a"], | ||
lambda x, **kwargs: DataFrame(x, **kwargs)[0], | ||
Index, | ||
], | ||
ids=["Series", "DataFrame-dict", "DataFrame-array", "Index"], | ||
) | ||
def constructor(request): | ||
return request.param | ||
|
||
|
||
class TestPandasDelegate: | ||
class Delegator: | ||
_properties = ["foo"] | ||
|
@@ -145,3 +158,14 @@ def test_constructor_datetime_outofbound(self, a, klass): | |
msg = "Out of bounds" | ||
with pytest.raises(pd.errors.OutOfBoundsDatetime, match=msg): | ||
klass(a, dtype="datetime64[ns]") | ||
|
||
def test_constructor_datetime_nonns(self, constructor): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add the issue number There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See a few lines below |
||
arr = np.array(["2020-01-01T00:00:00.000000"], dtype="datetime64[us]") | ||
expected = constructor(pd.to_datetime(["2020-01-01"])) | ||
result = constructor(arr) | ||
tm.assert_equal(result, expected) | ||
|
||
# https://github.com/pandas-dev/pandas/issues/34843 | ||
arr.flags.writeable = False | ||
result = constructor(arr) | ||
tm.assert_equal(result, expected) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:class:
for Series and Index? numpy -> NumPy?