Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: casting date to dt64 in maybe_promote #39767

Merged
merged 3 commits into from
Feb 15, 2021

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Feb 12, 2021

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

Once enforced, maybe_promote behavior will match DatetimeArray._validate_setitem_value and infer_dtype_from_scalar

sits on top of #39743

@jreback jreback added the Deprecate Functionality to remove in pandas label Feb 12, 2021
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great can you add a whatsnew :>

@jreback jreback added this to the 1.3 milestone Feb 12, 2021
@jreback jreback added the Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate label Feb 12, 2021
@jbrockmendel
Copy link
Member Author

great can you add a whatsnew :>

whatsnew added + green

@jreback jreback merged commit 61b8fc3 into pandas-dev:master Feb 15, 2021
@jreback
Copy link
Contributor

jreback commented Feb 15, 2021

thanks!

@jbrockmendel jbrockmendel deleted the ref-maybe_promote-infer branch February 16, 2021 00:07
@jbrockmendel
Copy link
Member Author

nice. getting close to done with the maybe_promote stuff. big outstanding one is #39769, then just numeric dtypes left

@jreback
Copy link
Contributor

jreback commented Feb 16, 2021

nice. getting close to done with the maybe_promote stuff. big outstanding one is #39769, then just numeric dtypes left

done too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants