Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: incorrectly accepting datetime64(nat) for dt64tz #39769

Merged
merged 3 commits into from
Feb 16, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback jreback added the Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate label Feb 12, 2021
@jreback jreback added this to the 1.3 milestone Feb 12, 2021
@jreback
Copy link
Contributor

jreback commented Feb 12, 2021

is this user facing at all?

@jbrockmendel
Copy link
Member Author

is this user facing at all?

yes. DatetimeIndex[tz].insert(np.datetime64("NaT")) now casts to object, and a bunch of the TestSetitemNADatetime64Dtype tests fail in master

@jreback
Copy link
Contributor

jreback commented Feb 12, 2021

is this user facing at all?

yes. DatetimeIndex[tz].insert(np.datetime64("NaT")) now casts to object, and a bunch of the TestSetitemNADatetime64Dtype tests fail in master

kk can you add a whatsnew :->

@jbrockmendel
Copy link
Member Author

whatsnew added + green

looking forward to the follow-up that de-duplicates a bunch of tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants