Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: consistency of input args for boundaries in DataFrame.between_time() #40245 #43248

Conversation

suyashgupta01
Copy link
Contributor

@suyashgupta01 suyashgupta01 commented Aug 27, 2021

@suyashgupta01
Copy link
Contributor Author

suyashgupta01 commented Aug 29, 2021

@jreback @attack68 Can you please take a look at this and approve the workflow. Also, let me know if any changes are required. Thanks!

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove .github/.pre-commit-config.yaml

.gitignore Outdated Show resolved Hide resolved
pandas/core/generic.py Outdated Show resolved Hide resolved
pandas/core/generic.py Outdated Show resolved Hide resolved
@suyashgupta01 suyashgupta01 force-pushed the new-boundary-inputs-pandas.DataFrame.between_time branch from 79bcde4 to 6e9882d Compare August 30, 2021 15:57
@suyashgupta01
Copy link
Contributor Author

@MarcoGorelli can you approve the workflows, please?

@suyashgupta01
Copy link
Contributor Author

@jreback It's all green, take a look :)

@suyashgupta01
Copy link
Contributor Author

@jreback Are any other changes required?

@jreback
Copy link
Contributor

jreback commented Sep 9, 2021

lgtm @attack68 @MarcoGorelli if any comments.

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nitpicks left, but the rest looks good to me!

pandas/core/generic.py Outdated Show resolved Hide resolved
pandas/core/generic.py Outdated Show resolved Hide resolved
inclusive = "both"
elif inclusive not in ["both", "neither", "left", "right"]:
raise ValueError(
f"Inclusive has to be either string of 'both',"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
f"Inclusive has to be either string of 'both',"
f"Inclusive has to be either string of 'both', "

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test will need updating here as well

@suyashgupta01
Copy link
Contributor Author

@MarcoGorelli Made the requested changes, please take a look :)

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me pending green, thanks @suyashgupta01 !

@suyashgupta01
Copy link
Contributor Author

@attack68 your review's pending, please take a look :)

@suyashgupta01
Copy link
Contributor Author

@MarcoGorelli Can you please take a look at the failing check, I can't figure out why it is failing?
https://github.com/pandas-dev/pandas/pull/43248/checks?check_run_id=3568087067

@MarcoGorelli
Copy link
Member

it's unrelated, don't worry about it

@jreback jreback merged commit df1de66 into pandas-dev:master Sep 10, 2021
@jreback
Copy link
Contributor

jreback commented Sep 10, 2021

thanks @suyashgupta01 ver nice

@suyashgupta01 suyashgupta01 deleted the new-boundary-inputs-pandas.DataFrame.between_time branch September 14, 2021 10:52
zhengruifeng pushed a commit to apache/spark that referenced this pull request Aug 18, 2023
…exer_between_time` for pandas 2.0.0 & enabling more tests

### What changes were proposed in this pull request?

This PR proposes to support `DatetimeIndex.indexer_between_time` to support pandas 2.0.0 and above. See pandas-dev/pandas#43248 for more detail.

This PR also enables bunch of tests for `Series`, `Index` and `GroupBy`.

### Why are the changes needed?

To match the behavior with latest pandas.

### Does this PR introduce _any_ user-facing change?

`DatetimeIndex.indexer_between_time` now has the same behavior with the latest pandas.

### How was this patch tested?

Enabling & updating the existing UTs and doctests.

Closes #42533 from itholic/enable-many-tests.

Authored-by: itholic <haejoon.lee@databricks.com>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
valentinp17 pushed a commit to valentinp17/spark that referenced this pull request Aug 24, 2023
…exer_between_time` for pandas 2.0.0 & enabling more tests

### What changes were proposed in this pull request?

This PR proposes to support `DatetimeIndex.indexer_between_time` to support pandas 2.0.0 and above. See pandas-dev/pandas#43248 for more detail.

This PR also enables bunch of tests for `Series`, `Index` and `GroupBy`.

### Why are the changes needed?

To match the behavior with latest pandas.

### Does this PR introduce _any_ user-facing change?

`DatetimeIndex.indexer_between_time` now has the same behavior with the latest pandas.

### How was this patch tested?

Enabling & updating the existing UTs and doctests.

Closes apache#42533 from itholic/enable-many-tests.

Authored-by: itholic <haejoon.lee@databricks.com>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
ragnarok56 pushed a commit to ragnarok56/spark that referenced this pull request Mar 2, 2024
…exer_between_time` for pandas 2.0.0 & enabling more tests

### What changes were proposed in this pull request?

This PR proposes to support `DatetimeIndex.indexer_between_time` to support pandas 2.0.0 and above. See pandas-dev/pandas#43248 for more detail.

This PR also enables bunch of tests for `Series`, `Index` and `GroupBy`.

### Why are the changes needed?

To match the behavior with latest pandas.

### Does this PR introduce _any_ user-facing change?

`DatetimeIndex.indexer_between_time` now has the same behavior with the latest pandas.

### How was this patch tested?

Enabling & updating the existing UTs and doctests.

Closes apache#42533 from itholic/enable-many-tests.

Authored-by: itholic <haejoon.lee@databricks.com>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions Deprecate Functionality to remove in pandas Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants