Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: consistency of input args for boundaries in DataFrame.between_time() #40245 #43248

Merged
merged 83 commits into from
Sep 10, 2021
Merged

ENH: consistency of input args for boundaries in DataFrame.between_time() #40245 #43248

merged 83 commits into from
Sep 10, 2021

Commits on Aug 24, 2021

  1. boundary inputs updated for DataFrame.between_time function

    @suyashgupta01
    suyashgupta01 committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    2a38350 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2021

  1. addev virtual environment to gitignore

    @suyashgupta01
    suyashgupta01 committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    4272175 View commit details
    Browse the repository at this point in the history

  2. added env to gitignore

    @suyashgupta01
    suyashgupta01 committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    ce929d2 View commit details
    Browse the repository at this point in the history

  3. resolved

    @suyashgupta01
    suyashgupta01 committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    113615e View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. tests work now

    @suyashgupta01
    suyashgupta01 committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    e0924f6 View commit details
    Browse the repository at this point in the history

  2. comments updated

    @suyashgupta01
    suyashgupta01 committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    b12957b View commit details
    Browse the repository at this point in the history

  3. deleted test_between_time.py backup (duplicate)

    @suyashgupta01
    suyashgupta01 committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    f1a0641 View commit details
    Browse the repository at this point in the history

  4. removed unused import

    @suyashgupta01
    suyashgupta01 committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    a7032c4 View commit details
    Browse the repository at this point in the history

  5. linting improvement

    @suyashgupta01
    suyashgupta01 committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    cb2ca4d View commit details
    Browse the repository at this point in the history

  6. aremoved debug print statements

    @suyashgupta01
    suyashgupta01 committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    c7f24de View commit details
    Browse the repository at this point in the history

  7. linting improvements

    @suyashgupta01
    suyashgupta01 committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    30be004 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'pandas-dev:master' into master

    @suyashgupta01
    suyashgupta01 authored Aug 27, 2021
    Configuration menu
    Copy the full SHA
    ff83813 View commit details
    Browse the repository at this point in the history

  9. linting improvement

    @suyashgupta01
    suyashgupta01 committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    83cd360 View commit details
    Browse the repository at this point in the history

  10. merging

    @suyashgupta01
    suyashgupta01 committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    6aacf78 View commit details
    Browse the repository at this point in the history

  11. updated docstring for between_time()

    @suyashgupta01
    suyashgupta01 committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    c94b34d View commit details
    Browse the repository at this point in the history

  12. made whats new entry

    @suyashgupta01
    suyashgupta01 committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    1e36cb2 View commit details
    Browse the repository at this point in the history

  13. linting improvement

    @suyashgupta01
    suyashgupta01 committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    1e6361b View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2021

  1. updated docstring for inclusive

    @suyashgupta01
    suyashgupta01 committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    236b8c3 View commit details
    Browse the repository at this point in the history

  2. making if statements consistent

    @suyashgupta01
    suyashgupta01 committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    01bf00e View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. precommit hook added

    @suyashgupta01
    suyashgupta01 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    5b35ac7 View commit details
    Browse the repository at this point in the history

  2. modified gitignore as per review

    @suyashgupta01
    suyashgupta01 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    ce00141 View commit details
    Browse the repository at this point in the history

  3. deleted .github/.pre-commit-config.yaml as per review

    @suyashgupta01
    suyashgupta01 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    99f35c3 View commit details
    Browse the repository at this point in the history

  4. bool_t: reconverted from string to annotation as per review

    @suyashgupta01
    suyashgupta01 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    101c0c2 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'pandas-dev:master' into master

    @suyashgupta01
    suyashgupta01 authored Aug 30, 2021
    Configuration menu
    Copy the full SHA
    40faba2 View commit details
    Browse the repository at this point in the history

  6. fetch from master and merge

    @suyashgupta01
    suyashgupta01 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    6e9882d View commit details
    Browse the repository at this point in the history

  7. used lib.no_default as per review

    @suyashgupta01
    suyashgupta01 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    d447d6b View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. preccommit hook changes

    @suyashgupta01
    suyashgupta01 committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    69a2891 View commit details
    Browse the repository at this point in the history

  2. removed venv files

    @suyashgupta01
    suyashgupta01 committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    226b961 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'pandas-dev:master' into master

    @suyashgupta01
    suyashgupta01 authored Aug 31, 2021
    Configuration menu
    Copy the full SHA
    6e3c42b View commit details
    Browse the repository at this point in the history

  4. fetched from upstream and merge

    @suyashgupta01
    suyashgupta01 committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    28cf632 View commit details
    Browse the repository at this point in the history

  5. Update pandas/core/generic.py to preserve args order 

    Co-authored-by: JHM Darbyshire <24256554+attack68@users.noreply.github.com>
    @suyashgupta01 @attack68
    suyashgupta01 and attack68 authored Aug 31, 2021
    Configuration menu
    Copy the full SHA
    2bb5c5a View commit details
    Browse the repository at this point in the history

  6. Update pandas/core/generic.py to preserve args order in docstring 

    Co-authored-by: JHM Darbyshire <24256554+attack68@users.noreply.github.com>
    @suyashgupta01 @attack68
    suyashgupta01 and attack68 authored Aug 31, 2021
    Configuration menu
    Copy the full SHA
    06d964c View commit details
    Browse the repository at this point in the history

  7. Update pandas/core/generic.py as per suggestion 

    Co-authored-by: JHM Darbyshire <24256554+attack68@users.noreply.github.com>
    @suyashgupta01 @attack68
    suyashgupta01 and attack68 authored Aug 31, 2021
    Configuration menu
    Copy the full SHA
    4946857 View commit details
    Browse the repository at this point in the history

  8. linting improvement

    @suyashgupta01
    suyashgupta01 committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    8df4bb6 View commit details
    Browse the repository at this point in the history

  9. test_between_time modified to accomodate previous review changes

    @suyashgupta01
    suyashgupta01 committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    3dcfd0b View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into new-boundary-inputs-pandas.DataFrame.betwe… 

    …en_time
    @suyashgupta01
    suyashgupta01 authored Aug 31, 2021
    Configuration menu
    Copy the full SHA
    5c013e3 View commit details
    Browse the repository at this point in the history

  11. updated docstring for CI error

    @suyashgupta01
    suyashgupta01 committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    7dbc6c4 View commit details
    Browse the repository at this point in the history

  12. removed fixture as per review

    @suyashgupta01
    suyashgupta01 committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    ccd35cd View commit details
    Browse the repository at this point in the history

  13. removed redundant msg as per review

    @suyashgupta01
    suyashgupta01 committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    f255d5e View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. removed redundant code

    @suyashgupta01
    suyashgupta01 committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    e9f109f View commit details
    Browse the repository at this point in the history

  2. error when user passes both new and depreciated args

    @suyashgupta01
    suyashgupta01 committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    c1f3f86 View commit details
    Browse the repository at this point in the history

  3. changed default value of inclusive to None fromm empty str

    @suyashgupta01
    suyashgupta01 committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    b26cc5c View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. ValueError message changed when both depreciated args and new args pa… 

    …ssed
    @suyashgupta01
    suyashgupta01 committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    5e3e193 View commit details
    Browse the repository at this point in the history

  2. comment updated when inclusive defaults to both

    @suyashgupta01
    suyashgupta01 committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    3bcb185 View commit details
    Browse the repository at this point in the history

  3. added deprecated directive for include_start and include_end

    @suyashgupta01
    suyashgupta01 committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    63975b4 View commit details
    Browse the repository at this point in the history

  4. deprecated directive updated

    @suyashgupta01
    suyashgupta01 committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    50cc20c View commit details
    Browse the repository at this point in the history

  5. version corrected in depreciate directive

    @suyashgupta01
    suyashgupta01 committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    4b6d817 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. Updated ValueError message as per review

    @suyashgupta01
    suyashgupta01 committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    1745349 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'pandas-dev:master' into master

    @suyashgupta01
    suyashgupta01 authored Sep 3, 2021
    Configuration menu
    Copy the full SHA
    2f60ba2 View commit details
    Browse the repository at this point in the history

  3. Fetch and merge

    @suyashgupta01
    suyashgupta01 committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    b5043cb View commit details
    Browse the repository at this point in the history

  4. updated docstring for between_time

    @suyashgupta01
    suyashgupta01 committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    da075f3 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2021

  1. test_between_time_incorr_arg_inclusive added

    @suyashgupta01
    suyashgupta01 committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    14e5450 View commit details
    Browse the repository at this point in the history

  2. tests added

    @suyashgupta01
    suyashgupta01 committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    8987d17 View commit details
    Browse the repository at this point in the history

  3. depreciated -> deprecated

    @suyashgupta01
    suyashgupta01 committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    693ad71 View commit details
    Browse the repository at this point in the history

  4. default type for inclusive mentioned as str

    @suyashgupta01
    suyashgupta01 committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    f49126b View commit details
    Browse the repository at this point in the history

  5. added message to match for FutureWarning in test_between_time_warn

    @suyashgupta01
    suyashgupta01 committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    6951d25 View commit details
    Browse the repository at this point in the history

  6. typo fix: added space to a ValueError message

    @suyashgupta01
    suyashgupta01 committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    0569ce3 View commit details
    Browse the repository at this point in the history

  7. default values updated for include_start, include_end

    @suyashgupta01
    suyashgupta01 committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    8d5d8c6 View commit details
    Browse the repository at this point in the history

  8. added missing functionality, modified test case for it

    @suyashgupta01
    suyashgupta01 committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    faabfdb View commit details
    Browse the repository at this point in the history

  9. modified between_time as per suggestion

    @suyashgupta01
    suyashgupta01 committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    12c787d View commit details
    Browse the repository at this point in the history

  10. Removed incorrect spaces from docstring for correct rendering 

    Co-authored-by: JHM Darbyshire <24256554+attack68@users.noreply.github.com>
    @suyashgupta01 @attack68
    suyashgupta01 and attack68 authored Sep 4, 2021
    Configuration menu
    Copy the full SHA
    5dae3f0 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2021

  1. Merge branch 'master' into new-boundary-inputs-pandas.DataFrame.betwe… 

    …en_time
    @suyashgupta01
    suyashgupta01 authored Sep 6, 2021
    Configuration menu
    Copy the full SHA
    56966f0 View commit details
    Browse the repository at this point in the history

  2. Modified test_between_time_incorr_arg_inclusive as per suggestion 

    Co-authored-by: JHM Darbyshire <24256554+attack68@users.noreply.github.com>
    @suyashgupta01 @attack68
    suyashgupta01 and attack68 authored Sep 6, 2021
    Configuration menu
    Copy the full SHA
    241c6a7 View commit details
    Browse the repository at this point in the history

  3. test_between_time_incompatiable_args_given parametrized

    @suyashgupta01
    suyashgupta01 committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    c0f0ada View commit details
    Browse the repository at this point in the history

  4. test added to assert functionality on both old, new args

    @suyashgupta01
    suyashgupta01 committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    e883702 View commit details
    Browse the repository at this point in the history

  5. infavour -> in favour

    @suyashgupta01
    suyashgupta01 committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    bb61353 View commit details
    Browse the repository at this point in the history

  6. docstring update as per suggestion 

    Co-authored-by: JHM Darbyshire <24256554+attack68@users.noreply.github.com>
    @suyashgupta01 @attack68
    suyashgupta01 and attack68 authored Sep 6, 2021
    Configuration menu
    Copy the full SHA
    605e144 View commit details
    Browse the repository at this point in the history

  7. git pull from remote

    @suyashgupta01
    suyashgupta01 committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    2ecb812 View commit details
    Browse the repository at this point in the history

  8. mpyerror fixed

    @suyashgupta01
    suyashgupta01 committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    38a2aa1 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. changed order of args as per suggestion in between_time

    @suyashgupta01
    suyashgupta01 committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    dcafe0c View commit details
    Browse the repository at this point in the history

  2. replaced parametrize with fixture as per suggestion in test_between_time

    @suyashgupta01
    suyashgupta01 committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    84543b8 View commit details
    Browse the repository at this point in the history

  3. readability update in test_between_time.py

    @suyashgupta01
    suyashgupta01 committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    48bd780 View commit details
    Browse the repository at this point in the history

  4. comment # GH40245 shifted inside test definitions

    @suyashgupta01
    suyashgupta01 committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    6eb02d7 View commit details
    Browse the repository at this point in the history

  5. readability update x,y -> result, expected

    @suyashgupta01
    suyashgupta01 committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    519113b View commit details
    Browse the repository at this point in the history

  6. used assert_frame_equal ito compare frames

    @suyashgupta01
    suyashgupta01 committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    b701430 View commit details
    Browse the repository at this point in the history

  7. updated generic.py

    @suyashgupta01
    suyashgupta01 committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    938d39a View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. removed comment as per suggestion

    @suyashgupta01
    suyashgupta01 committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    fdfa53f View commit details
    Browse the repository at this point in the history

  2. added , default True iin docstring for inc_start, inc_end in between_… 

    …time
    @suyashgupta01
    suyashgupta01 committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    0796bc4 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. close -> closed as per suggestion 

    Co-authored-by: Marco Edward Gorelli <marcogorelli@protonmail.com>
    @suyashgupta01 @MarcoGorelli
    suyashgupta01 and MarcoGorelli authored Sep 10, 2021
    Configuration menu
    Copy the full SHA
    b1fa8d6 View commit details
    Browse the repository at this point in the history

  2. close -> closed as per suggestion 

    Co-authored-by: Marco Edward Gorelli <marcogorelli@protonmail.com>
    @suyashgupta01 @MarcoGorelli
    suyashgupta01 and MarcoGorelli authored Sep 10, 2021
    Configuration menu
    Copy the full SHA
    6c10418 View commit details
    Browse the repository at this point in the history

  3. added a space in ValueError msg for readability

    @suyashgupta01
    suyashgupta01 committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    186b7a3 View commit details
    Browse the repository at this point in the history

  4. git pull and merge

    @suyashgupta01
    suyashgupta01 committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    ba02ad1 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into new-boundary-inputs-pandas.DataFrame.betwe… 

    …en_time
    @suyashgupta01
    suyashgupta01 authored Sep 10, 2021
    Configuration menu
    Copy the full SHA
    63de5a2 View commit details
    Browse the repository at this point in the history