Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: consistency of input args for boundaries - pd.interval_range #46355

Merged
merged 46 commits into from
Apr 4, 2022

Conversation

weikhor
Copy link
Contributor

@weikhor weikhor commented Mar 13, 2022

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deprecation means actually deprecating the paremeter & testing it

pandas/core/indexes/interval.py Outdated Show resolved Hide resolved
@jreback jreback added Interval Interval data type Deprecate Functionality to remove in pandas labels Mar 16, 2022
@jreback
Copy link
Contributor

jreback commented Mar 16, 2022

see the other PRs on that issue for how to do this.

@weikhor weikhor force-pushed the enh-consistency-interval-range branch from d42d343 to b6bc361 Compare March 19, 2022 14:30
@weikhor weikhor requested a review from jreback March 19, 2022 14:40
@weikhor weikhor requested a review from jreback March 20, 2022 14:55
@jreback
Copy link
Contributor

jreback commented Mar 20, 2022

pandas/core/indexes/interval.py:1152: error: Argument "closed" to "from_breaks" of "IntervalIndex" has incompatible type "Optional[str]"; expected "str" [arg-type]

@weikhor weikhor force-pushed the enh-consistency-interval-range branch from ae6a4f9 to 1c41aa0 Compare March 22, 2022 16:29
@pep8speaks
Copy link

pep8speaks commented Mar 27, 2022

Hello @weikhor! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-04-03 07:28:29 UTC

pandas/core/indexes/interval.py Show resolved Hide resolved
pandas/core/indexes/interval.py Show resolved Hide resolved
@weikhor weikhor requested a review from jreback March 29, 2022 15:32
pandas/core/indexes/interval.py Show resolved Hide resolved
pandas/core/indexes/interval.py Show resolved Hide resolved
@weikhor weikhor requested a review from jreback April 3, 2022 15:58
@jreback jreback added this to the 1.5 milestone Apr 4, 2022
@jreback jreback merged commit 073b353 into pandas-dev:main Apr 4, 2022
@jreback
Copy link
Contributor

jreback commented Apr 4, 2022

thanks @weikhor

@weikhor weikhor deleted the enh-consistency-interval-range branch May 31, 2022 16:12
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
mroeschke added a commit to mroeschke/pandas that referenced this pull request Aug 17, 2022
mroeschke added a commit that referenced this pull request Aug 18, 2022
…48116)

* Revert "Cln tests interval wrt inclusive (#47775)"

This reverts commit 2d6e0b2.

* Revert "CLN: Rename private variables to inclusive  (#47655)"

This reverts commit 102b3ca.

* Revert "TYP: Improve typing interval inclusive (#47646)"

This reverts commit 5506476.

* Revert "DEPR: Deprecate set_closed and add set_incluive (#47636)"

This reverts commit bd4ff39.

* Revert "DEPR: Remove deprecation from private class IntervalTree (#47637)"

This reverts commit f6658ef.

* Revert "Revert inclusive default change of IntervalDtype (#47367)"

This reverts commit d9dd128.

* Revert "ENH: consistency of input args for boundaries - Interval (#46522)"

This reverts commit 7e23a37.

* Revert "ENH: consistency of input args for boundaries -  pd.interval_range (#46355)"

This reverts commit 073b353.

* Fix ArrowIntervalType manually

* Remove unused import

* Fix doctest and leftover usage

* Fix remaining tests

* Fix wording in doctoring

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
…andas-dev#48116)

* Revert "Cln tests interval wrt inclusive (pandas-dev#47775)"

This reverts commit 2d6e0b2.

* Revert "CLN: Rename private variables to inclusive  (pandas-dev#47655)"

This reverts commit 102b3ca.

* Revert "TYP: Improve typing interval inclusive (pandas-dev#47646)"

This reverts commit 5506476.

* Revert "DEPR: Deprecate set_closed and add set_incluive (pandas-dev#47636)"

This reverts commit bd4ff39.

* Revert "DEPR: Remove deprecation from private class IntervalTree (pandas-dev#47637)"

This reverts commit f6658ef.

* Revert "Revert inclusive default change of IntervalDtype (pandas-dev#47367)"

This reverts commit d9dd128.

* Revert "ENH: consistency of input args for boundaries - Interval (pandas-dev#46522)"

This reverts commit 7e23a37.

* Revert "ENH: consistency of input args for boundaries -  pd.interval_range (pandas-dev#46355)"

This reverts commit 073b353.

* Fix ArrowIntervalType manually

* Remove unused import

* Fix doctest and leftover usage

* Fix remaining tests

* Fix wording in doctoring

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Interval Interval data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants