TYP: Improve typing interval inclusive #47646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Interval
twoertwein
approved these changes
Jul 8, 2022
|
lgtm can you rebase |
…rval_inclusive # Conflicts: # pandas/core/arrays/interval.py
|
Done |
|
Thank you @phofl |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* TYP: Make typing of inclusive consistent * Fix comparison * Fix typing issues * Try fixing pyright
mroeschke
added a commit
to mroeschke/pandas
that referenced
this pull request
Aug 17, 2022
This reverts commit 5506476.
mroeschke
added a commit
that referenced
this pull request
Aug 18, 2022
…48116) * Revert "Cln tests interval wrt inclusive (#47775)" This reverts commit 2d6e0b2. * Revert "CLN: Rename private variables to inclusive (#47655)" This reverts commit 102b3ca. * Revert "TYP: Improve typing interval inclusive (#47646)" This reverts commit 5506476. * Revert "DEPR: Deprecate set_closed and add set_incluive (#47636)" This reverts commit bd4ff39. * Revert "DEPR: Remove deprecation from private class IntervalTree (#47637)" This reverts commit f6658ef. * Revert "Revert inclusive default change of IntervalDtype (#47367)" This reverts commit d9dd128. * Revert "ENH: consistency of input args for boundaries - Interval (#46522)" This reverts commit 7e23a37. * Revert "ENH: consistency of input args for boundaries - pd.interval_range (#46355)" This reverts commit 073b353. * Fix ArrowIntervalType manually * Remove unused import * Fix doctest and leftover usage * Fix remaining tests * Fix wording in doctoring Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…andas-dev#48116) * Revert "Cln tests interval wrt inclusive (pandas-dev#47775)" This reverts commit 2d6e0b2. * Revert "CLN: Rename private variables to inclusive (pandas-dev#47655)" This reverts commit 102b3ca. * Revert "TYP: Improve typing interval inclusive (pandas-dev#47646)" This reverts commit 5506476. * Revert "DEPR: Deprecate set_closed and add set_incluive (pandas-dev#47636)" This reverts commit bd4ff39. * Revert "DEPR: Remove deprecation from private class IntervalTree (pandas-dev#47637)" This reverts commit f6658ef. * Revert "Revert inclusive default change of IntervalDtype (pandas-dev#47367)" This reverts commit d9dd128. * Revert "ENH: consistency of input args for boundaries - Interval (pandas-dev#46522)" This reverts commit 7e23a37. * Revert "ENH: consistency of input args for boundaries - pd.interval_range (pandas-dev#46355)" This reverts commit 073b353. * Fix ArrowIntervalType manually * Remove unused import * Fix doctest and leftover usage * Fix remaining tests * Fix wording in doctoring Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the usage of IntervalInclusiveType consistent. Also renamed for consistency with new argument