Bug Fix: pd.DataFrame.sum with min_count changes dtype if result contains NaNs #47091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 22, 2022 23:05
…weikhor/pandas into bug_fix_min_count_changes_dtype
phofl
reviewed
May 27, 2022
pandas/core/nanops.py
Outdated
| @@ -1472,7 +1472,8 @@ def _maybe_null_out( | |||
| if np.iscomplexobj(result): | |||
| result = result.astype("c16") | |||
| else: | |||
| result = result.astype("f8") | |||
| if not is_float_dtype(result): | |||
| result = result.astype("f8") | |||
phofl
reviewed
May 27, 2022
doc/source/whatsnew/v1.5.0.rst
Outdated
| @@ -780,7 +780,7 @@ Indexing | |||
| - Bug in setting large integer values into :class:`Series` with ``float32`` or ``float16`` dtype incorrectly altering these values instead of coercing to ``float64`` dtype (:issue:`45844`) | |||
| - Bug in :meth:`Series.asof` and :meth:`DataFrame.asof` incorrectly casting bool-dtype results to ``float64`` dtype (:issue:`16063`) | |||
| - Bug in :meth:`NDFrame.xs`, :meth:`DataFrame.iterrows`, :meth:`DataFrame.loc` and :meth:`DataFrame.iloc` not always propagating metadata (:issue:`28283`) | |||
| - | |||
| - Bug in :meth:`_maybe_null_out` pd.DataFrame.sum with min_count changes dtype if result contains NaNs | |||
There was a problem hiding this comment.
_maybe_null_out is private. Please reference the public functions, e.g. sum
phofl
reviewed
May 27, 2022
| # GH#46947 | ||
| df = DataFrame({"a": [1.0, 2.3, 4.4], "b": [2.2, 3, np.nan]}, dtype="float32") | ||
| result = df.sum(**kwargs).dtype | ||
| assert result == "float32" |
There was a problem hiding this comment.
Please test the whole DataFrame and parametrize over all possible float dtypes.
jreback
added
Bug
Dtype Conversions
|
thanks @weikhor very nice. can you add similar tests for |
4 tasks
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.