Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Case: pd.DataFrame.prob with min_count changes dtype if result contains NaNs #47170

Merged
merged 16 commits into from
May 30, 2022

Conversation

weikhor
Copy link
Contributor

@weikhor weikhor commented May 30, 2022

@weikhor weikhor changed the title Bug fix min count changes dtype Test Case: pd.DataFrame.prob with min_count changes dtype if result contains NaNs May 30, 2022
@weikhor
Copy link
Contributor Author

weikhor commented May 30, 2022

Hi @jreback

This PR is about to add test cases for pd.prob - #47091 (comment)

@jreback jreback added the Testing pandas testing functions or related to the test suite label May 30, 2022
@jreback jreback added this to the 1.5 milestone May 30, 2022
@jreback jreback merged commit 9289c46 into pandas-dev:main May 30, 2022
@jreback
Copy link
Contributor

jreback commented May 30, 2022

thanks @weikhor very nice!

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants