-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fix version switcher in old docs #48600
Conversation
I'm adding here |
@phofl do you mind having a quick look at this please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thx @datapythonista 1.6 is fine as milestone? |
I think for PRs only affecting the website we don't need to backport anything. Is the milestone useful for anything else other than backporting? Looks like this PR didn't work as expected. :( Luckily I understand the problem now. In the new version, the I can restore the Funny enough, this change in behavior made that even the switcher in the pydata theme page is broken. Try to change the version in their old docs: https://pydata-sphinx-theme.readthedocs.io/en/v0.8.0/user_guide/configuring.html |
Fixing the version switcher in old versions of the documentation.
I'm also removing here the duplicated 1.4 link in the version switcher.