-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version switcher not working for old docs #932
Comments
It looks like in our documentation this problem begins with
It seems like on For your theme, could you backport an update to your documentation so that the pydata theme is updated and thus the switcher configuration behaves properly? I don't think there is anything that we can do about this for the pydata theme, because we can't backport a higher version of our own theme to the documentation of the same theme. IMO our solution should be to remove documentation for versions older than ~0.8.1 @drammock could you provide a rationale for why you think this issue should block any future releases? |
For us it broke in the release we started using url instead of version, so we kept the versions broken in the json, and the links are working well now. I think version is also used to compare the current version, and that may be broken, but not quite sure if there is anything not fully working. |
My feeling is that we don't want to block all future releases on this issue, and we should remove the |
agreed. I've removed the tag. I initially added it somewhat hastily without looking closely enough at what the problem was. I'd like to leave this open though as a reminder to consider backporting a fix... IMO there is a valid use case for switching back and forth between current and older doc versions (namely, figuring out when a change was introduced if it's not in the changelog), which requires that the switcher work correctly on the older sites. |
Definitely agree we should track this one - though I'm still not sure yet what the underlying fix needs to be. |
…me#932) doesn't look like it's getting fixed any time soon, pinning to earlier version
…me#932) doesn't look like it's getting fixed any time soon, pinning to earlier version
…me#932) doesn't look like it's getting fixed any time soon, pinning to earlier version
…me#932) doesn't look like it's getting fixed any time soon, pinning to earlier version
@datapythonista, we actually dropped the version 0.8 from our version switcher so this is no longer a bug for us. did you find a workaround from your side or is it still an active issue ? |
Thank you for your issue! We haven't gotten a response to our questions in our comment #932 (comment). With only the current information on the issue, we don't have enough information to take action. I'm going to close this, but don't hesitate to reach out if you have or find the answers we need. We'll be happy to reopen the issue. |
In your own website, if you're in an old version of the docs, the links in the version switcher are incorrect. Change version from example from here: https://pydata-sphinx-theme.readthedocs.io/en/v0.8.0/index.html
We had a similar problem with pandas, for context see this comment: pandas-dev/pandas#48600 (comment)
The text was updated successfully, but these errors were encountered: