Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: pinning name in SeriesGroupBy.agg #51703

Merged
merged 2 commits into from
Mar 3, 2023
Merged

DEPR: pinning name in SeriesGroupBy.agg #51703

merged 2 commits into from
Mar 3, 2023

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Mar 1, 2023 •
edited
Loading

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

xref #41090 doesn't fully close it as there are other places that use the deprecated pattern.

Need a good "use X instead" for the warning messsage.

@jbrockmendel jbrockmendel added Groupby Deprecate Functionality to remove in pandas labels Mar 1, 2023
@rhshadrach
Copy link
Member

What about:

If your operation requires utilizing the groupby keys, iterate over the groupby object instead.

@jbrockmendel
Copy link
Member Author

Good idea, updated

@rhshadrach rhshadrach added this to the 2.1 milestone Mar 3, 2023
rhshadrach
rhshadrach approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach merged commit 455ffb2 into pandas-dev:main Mar 3, 2023
@rhshadrach
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the depr-aggregate_named branch March 3, 2023 02:31
@rhshadrach rhshadrach mentioned this pull request Mar 6, 2023
Open
@rhshadrach rhshadrach mentioned this pull request Feb 29, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Groupby
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @rhshadrach