MAINT: Remove np.int_ and np.uint
#55369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsokol
force-pushed
the
remove-int_-and-uint
branch
from
c755e00 to
0ea5e62
Compare
mtsokol
force-pushed
the
remove-int_-and-uint
branch
from
0ea5e62 to
9e65df2
Compare
mroeschke
reviewed
Oct 3, 2023
| np_long = np.int_ | ||
| np_ulong = np.uint | ||
| else: | ||
| np_long = np.int_ |
There was a problem hiding this comment.
So just for my understanding, np.long was newly added to the top level namespace/didn't exist before a certain version? It would be preferable to already use np.long/np.ulong if possible
There was a problem hiding this comment.
That's correct - np.long and np.ulong throw AttributeError in existing numpy versions - these will be new members of the main namespace (I think np.long existed for some time a long time ago).
mroeschke
added
the
Compat
mroeschke
approved these changes
Oct 3, 2023
|
Thanks again @mtsokol |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 3, 2023
|
I think I need to add one warning filter, similar to scipy scipy/scipy#19341 that I did today - in case you experience failures with the current numpy nightly. |
mtsokol
added a commit
to mtsokol/pandas
that referenced
this pull request
Oct 13, 2023
This reverts commit 4976b69.
|
These changes should be reverted in #55505, and also reverse-backported to 2.1.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR addresses changes that will be shipped in numpy/numpy#24794 - deprecation of
np.int_andnp.uint. An explanation of changes:np.int_(value)was used I replaced it with backward compatiblenp_long(value).np.int_withnp.dtype(int)(they are equivalent).dtype=arguments I usedintfor conciseness.